-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] [CP Staging] Fix concierge avatar in mention suggestion #41034
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Re-assigning C+ as noted here |
Reviewer Checklist
Screenshots/Videos |
@@ -86,6 +86,7 @@ function MentionSuggestions({prefix, mentions, highlightedMentionIndex = 0, onSe | |||
type={item.icons[0].type} | |||
fill={isIcon ? theme.success : undefined} | |||
fallbackIcon={item.icons[0].fallbackIcon} | |||
accountID={item.icons[0].id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to do optional chaining here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the check in line 80:
{item.icons && !!item.icons.length && (
seems to guarantee icons always being there, so no need to optional chain here IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. Looks good otherwise.
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am adding hold temporarily to see if its better to revert the offending PR, seems like there is couple of deploy blockers linked to it and we are close to deploying, this is not critical change so we can revert and fix this in a follow up |
what are the other deploy blockers? |
Proceeding with the revert because it fixes 3 blockers #41087 (linked in the PR) (one of them is partial fix - ie the behaviour was not perfect before) We are close to deploy on Friday as regression is almost complete so choosing revert route and you will have enough time to handle the fixes in the second iteration of the PR |
Ended up reverting the offending PR so this wont be needed anymore #41087 |
Details
Fixed Issues
$ #41014
PROPOSAL: #41014 (comment)
Tests
@concierge@expensify.com
in the composerBefore:
After:
Offline tests
Same as tests but offline
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Tests screenshots are shown above. I only tested on desktop since the changes are platform independent and very small.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop