Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Remove 'OptionsSelector' component #41077

Merged
merged 37 commits into from
May 15, 2024
Merged

[TS migration] Remove 'OptionsSelector' component #41077

merged 37 commits into from
May 15, 2024

Commits on Apr 23, 2024

  1. wip

    @war-in
    war-in committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e3e9e7b View commit details
    Browse the repository at this point in the history

  2. wip....

    @war-in
    war-in committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0ab6923 View commit details
    Browse the repository at this point in the history

  3. show tick next to payee

    @war-in
    war-in committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3f1c13c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. show amount

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7cd7718 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/main' into war-in/options-selector-removal

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0eff692 View commit details
    Browse the repository at this point in the history

  3. align items

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b05192b View commit details
    Browse the repository at this point in the history

  4. remove optionsSelector

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1e65a85 View commit details
    Browse the repository at this point in the history

  5. fix typecheck

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    affc169 View commit details
    Browse the repository at this point in the history

  6. styling

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1ad6d78 View commit details
    Browse the repository at this point in the history

  7. add correct styling

    @war-in
    war-in committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3db3fb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. use ScrollView

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f5148ed View commit details
    Browse the repository at this point in the history

  2. add second ScrollView to get rid of error

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    115be37 View commit details
    Browse the repository at this point in the history

  3. styling

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    01840ca View commit details
    Browse the repository at this point in the history

  4. use SelectionList as main component

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    04b9907 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'refs/heads/main' into war-in/options-selector-removal

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dadec41 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b34b47e View commit details
    Browse the repository at this point in the history

  7. move children to listFooterContent

    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    08b162e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
#	src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx
    @war-in
    war-in committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1259b8d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
    @war-in
    war-in committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3eb6751 View commit details
    Browse the repository at this point in the history

  2. prettier

    @war-in
    war-in committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    eb8d61e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
    @war-in
    war-in committed May 6, 2024
    Configuration menu
    Copy the full SHA
    830d71c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. review suggestions

    @war-in
    war-in committed May 7, 2024
    Configuration menu
    Copy the full SHA
    48d9fdd View commit details
    Browse the repository at this point in the history

  2. add styles and do not show ✅

    @war-in
    war-in committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3d36eb2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
    @war-in
    war-in committed May 7, 2024
    Configuration menu
    Copy the full SHA
    838ebdf View commit details
    Browse the repository at this point in the history

  4. wip

    @war-in
    war-in committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6adda9c View commit details
    Browse the repository at this point in the history

  5. almost done (there are still some bugs)

    @war-in
    war-in committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fbb7b60 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. fix errors

    @war-in
    war-in committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f2ba6c4 View commit details
    Browse the repository at this point in the history

  2. fix typecheck

    @war-in
    war-in committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0ad9d3a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
    @war-in
    war-in committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d673fc0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/main' into war-in/options-selector-removal

    @war-in
    war-in committed May 13, 2024
    Configuration menu
    Copy the full SHA
    492ea96 View commit details
    Browse the repository at this point in the history

  3. remove ArrowKeyFocusManager.js

    @war-in
    war-in committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c274163 View commit details
    Browse the repository at this point in the history

  4. show non-editable amount when needed

    @war-in
    war-in committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d9a5d2f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'refs/heads/main' into war-in/options-selector-removal 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.tsx
    @war-in
    war-in committed May 13, 2024
    Configuration menu
    Copy the full SHA
    de9138d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'refs/heads/main' into war-in/options-selector-removal

    @war-in
    war-in committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dcc0582 View commit details
    Browse the repository at this point in the history

  2. fix padding

    @war-in
    war-in committed May 14, 2024
    Configuration menu
    Copy the full SHA
    929d7f1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/main' into war-in/options-selector-removal

    @war-in
    war-in committed May 14, 2024
    Configuration menu
    Copy the full SHA
    720900d View commit details
    Browse the repository at this point in the history

  4. padding -> margin

    @war-in
    war-in committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8cc152c View commit details
    Browse the repository at this point in the history