Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taxes read-only when connected to accounting integration #41785

Conversation

SzymczakJ
Copy link
Contributor

@SzymczakJ SzymczakJ commented May 7, 2024

Details

When connected to accounting integration(QBO or Xero) taxes, tags and categories should be read-only(user cannot delete/add them). This PR covers that.

Fixed Issues

$ #39911
PROPOSAL: N/A

Tests

  • Connect to accounting integration(Xero or QBO)
  • import tags from accounting integration(shown on ss)
Screenshot 2024-05-08 at 10 40 13
  • Go to workspace tags page and make sure you cannot add or delete tags
  • import taxes from accounting integration(there is a bug in importing taxes to test taxes take a look on this)
  • Go to workspace taxes page and make sure you cannot add or delete taxes

Offline tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop

@SzymczakJ SzymczakJ changed the title make taxes read only Make taxes read-only when connected to accounting integration May 7, 2024
Copy link
Contributor

@Kicu Kicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SzymczakJ SzymczakJ marked this pull request as ready for review May 8, 2024 09:57
@SzymczakJ SzymczakJ requested a review from a team as a code owner May 8, 2024 09:57
@melvin-bot melvin-bot bot requested review from dukenv0307 and removed request for a team May 8, 2024 09:57
Copy link

melvin-bot bot commented May 8, 2024

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented May 8, 2024

@SzymczakJ, please also take a look at these comments (this one and this one) 🙇

@dukenv0307
Copy link
Contributor

Do we need C+ here?

@SzymczakJ
Copy link
Contributor Author

We are waiting for Xero import features to be merged so we can reliably test this. I can ping you when it's ready 😄 @dukenv0307

@dukenv0307
Copy link
Contributor

@SzymczakJ Thank you

@lakchote lakchote changed the base branch from main to xero-merge-freeze May 10, 2024 10:28
@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented May 10, 2024

Let's use PolicyUtils.hasAccountingConnections in WorkspaceCategoriesPage as well 😄

->

const isThereAnyAccountingConnection = Object.keys(policy?.connections ?? {}).length !== 0;

@hayata-suenaga
Copy link
Contributor

@SzymczakJ let me know your ETA 😄

@lakchote lakchote deleted the branch Expensify:xero-merge-freeze May 14, 2024 08:47
@lakchote lakchote closed this May 14, 2024
@SzymczakJ
Copy link
Contributor Author

@hayata-suenaga I'll try to complete this tomorrow(if backend for xero will be working(for now it's not))

@hayata-suenaga
Copy link
Contributor

@lakchote, why did you close this PR? 😄

@SzymczakJ
Copy link
Contributor Author

Created a new PR addressing this. It is only touching taking care of taxes page because tags were fixed in some other PR.

@lakchote
Copy link
Contributor

@lakchote, why did you close this PR? 😄

Hmm, thanks @hayata-suenaga for pinging me, at first I thought I was becoming crazy but I found the reason 😄

I merged the xero-merge-freeze branch yesterday, which automatically deleted the branch, which automatically closed this pull request who had this branch as target branch.

@hayata-suenaga
Copy link
Contributor

Screenshot 2024-05-15 at 10 31 54 AM

ah I see it 😆 thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants