-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix footer moves down and up a bit when keyboard show/close #42127
Fix footer moves down and up a bit when keyboard show/close #42127
Conversation
This issue also happens on other pages, for example, the chat finder page. Screen.Recording.2024-05-14.at.13.14.13.movHere is the video after fix: Screen.Recording.2024-05-14.at.13.14.59.mov |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome01_Android_Native.mp4iOS: Native02_Android_Chrome.mp4iOS: mWeb Safari02_Android_Chrome.mp4MacOS: Chrome / Safari03_iOS_Native.mp4MacOS: Desktop03_iOS_Native.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀
|
Details
The padding is currently added based on the keyboard state, so it will changes when closing/showing the keyboard.
Fixed Issues
$ #41855
PROPOSAL: #41855 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
mWeb/Android/iOS
Web/Desktop
No keyboard, so just make sure the footer button still has some space from the bottom of the page.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-14.at.13.27.52.mov
Android: mWeb Chrome
Screen.Recording.2024-05-14.at.13.24.16.mov
iOS: Native
Screen.Recording.2024-05-14.at.13.15.26.mov
iOS: mWeb Safari
Screen.Recording.2024-05-14.at.13.22.13.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-14.at.13.21.21.mov
MacOS: Desktop
Screen.Recording.2024-05-14.at.13.21.40.mov