Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android anchor markdown format 40564 #42147

Merged
merged 6 commits into from
May 24, 2024
Merged

Android anchor markdown format 40564 #42147

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0aecb3
Fixed anchor links when copied from android native from composer
samilabud May 10, 2024
4b44324
Merge branch 'main' into android_anchor_markdown_format_40564
samilabud May 14, 2024
72a163d
Merge branch 'main' into android_anchor_markdown_format_40564
samilabud May 15, 2024
0ed65b7
Merge branch 'main' into android_anchor_markdown_format_40564
samilabud May 17, 2024
3857608
Updated regex to get link in href prop inside of <a/> component
samilabud May 17, 2024
e4a4d6e
Created and used constant to get the link in href inside anchor tag
samilabud May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/home/report/ContextMenu/ContextMenuActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@
if (!Clipboard.canSetHtml()) {
Clipboard.setString(parser.htmlToMarkdown(content));
} else {
const plainText = parser.htmlToText(content);
const anchorRegex = /<a\s+(?:[^>]*?\s+)?href="([^"]*)"/gi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a CONST for this regex to avoid duplicated code?

Copy link
Contributor

@DylanDylann DylanDylann May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samilabud Please test again to make sure this regex also works well

const isAnchorTag = anchorRegex.test(content);
console.log({isAnchorTag});

Check failure on line 50 in src/pages/home/report/ContextMenu/ContextMenuActions.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unexpected console statement
const plainText = isAnchorTag ? parser.htmlToMarkdown(content) : parser.htmlToText(content);
Clipboard.setHtml(content, plainText);
}
}
Expand Down
Loading