-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix: Chat - Display Name Appears Black and Members Not Ticked in Group Preview #42805
[CP Staging] fix: Chat - Display Name Appears Black and Members Not Ticked in Group Preview #42805
Conversation
…p Preview. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@Krishna2323 lint and ts checks are failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 can you check the failing lint and ts checks?
@luacmartins @abdulrahuman5196, the typecheck failure and linting issues are not coming from our PR. I have added all the screenshots except for the Android native. I'm facing a build issue and it seems I need to reclone the repo to fix that. However, my internet connection is currently slow. I will update tomorrow morning or in 3-4 hours if the broadband is fixed. |
Looking for solution. |
Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
@luacmartins, all checks passed. Should I tick the android recording video check or wait until my internet connection fixes. |
@Krishna2323 we have conflicts now 😞 |
@luacmartins, conflicts resolved. |
@abdulrahuman5196 could you please prioritize reviewing this one since it fixes a blocker? |
Hi, yes. Starting to check it. |
Sorry for the delay. Checking again. |
@abdulrahuman5196 how's the review going? |
@luacmartins I just now checked in desktop and its fine there. But having trouble to test in all platforms due to site issues. Seems expensify is partially down https://status.expensify.com/ |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-05-30.at.8.47.27.PM.mp4Android: mWeb ChromeScreen.Recording.2024-05-30.at.7.22.42.PM.mp4iOS: NativeScreen.Recording.2024-05-30.at.8.38.46.PM.mp4iOS: mWeb SafariScreen.Recording.2024-05-30.at.7.25.08.PM.mp4MacOS: Chrome / SafariScreen.Recording.2024-05-30.at.7.18.36.PM.mp4MacOS: DesktopScreen.Recording.2024-05-30.at.7.15.38.PM.mp4 |
@abdulrahuman5196, since you have tested on Android, can I skip recording for Android? I'm still facing build issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @luacmartins
🎀 👀 🎀
C+ Reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] fix: Chat - Display Name Appears Black and Members Not Ticked in Group Preview (cherry picked from commit 99b0563)
…ing-42805-1 🍒 Cherry pick PR #42805 to staging 🍒
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
Details
Fixed Issues
$ #42751
PROPOSAL: #42751 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4