-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loading state to the SettlementButton #42981
feat: add loading state to the SettlementButton #42981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ready for review :) @Expensify/design |
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I think @rayane-djouah should review this one, as he was C+ in the original issue and has more context. |
@rayane-djouah is out of office now for a bit, @eVoloshchak please continue with the C+ review! @kosmydel looks like we have conflicts. :) |
Interesting, I have no idea if we have a custom loading spinner that looks the same on iOS and Android as well. @marcaaron for some reason I vaguely remember you implementing the loading spinner years ago. Do you know if it should look the same on all platforms, or if we use a native spinner on iOS? |
Done, I've resolved conflicts. I believe we are waiting for confirmation of the spinner's design for native. |
Keen to hear what @marcaaron says. I noticed we used |
Ah I'm keen to hear back too. I never realized that the loader changed on different platforms. I don't feel super strongly either, and I think as long as we're reusing whatever loader component we use, it's probably fine (even if they look slightly different on different platforms). |
I am 99% sure that we use the native loading indicator which is what the stock React Native component provides. |
Friendly bump @eVoloshchak |
Reviewer Checklist
Screenshots/VideosAndroid: Native24-06-13-17-11-14.mp4Android: mWeb ChromeScreen.Recording.2024-06-13.at.17.09.12.moviOS: NativeScreen.Recording.2024-06-13.at.17.05.27.moviOS: mWeb SafariScreen.Recording.2024-06-13.at.17.08.06.movMacOS: Chrome / SafariScreen.Recording.2024-06-13.at.16.58.31.movMacOS: DesktopScreen.Recording.2024-06-13.at.17.03.48.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #41445 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.84-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.84-3 🚀
|
Details
This PR aim "is to show a loading state on the settlement button when online and currency conversion is in progress, and to disable the settlement button when offline to avoid implementing an endless loading spinner." (comment)
Fixed Issues
$ #41445
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome & iOS: mWeb Safari
mweb.mov
iOS: Native
ios.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov