fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794

Krishna2323 · 2024-06-15T02:48:11Z

Details

Fixed Issues

$ #41848
PROPOSAL: #41848 (comment)

Tests

Go to group chat.
Go to + > Split expense.
Enter amount > Next.
On confirmation page, hit CMD+Enter.
Verify the request is submitted.
Repeat step 2 and 3 > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any amount input using tab key > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any participant using up/down arrow key > hit Enter
Verify participant details page is opened.
Go back and Focus on any participant using up/down arrow key
After participant is focused use Tab key to focus amount input
Hit CMD+Enter/Enter > Verify the request is submitted

Verify that no errors appear in the JS console

Offline tests

Go to group chat.
Go to + > Split expense.
Enter amount > Next.
On confirmation page, hit CMD+Enter.
Verify the request is submitted.
Repeat step 2 and 3 > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any amount input using tab key > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any participant using up/down arrow key > hit Enter
Verify participant details page is opened.
Go back and Focus on any participant using up/down arrow key
After participant is focused use Tab key to focus amount input
Hit CMD+Enter/Enter > Verify the request is submitted

QA Steps

Go to group chat.
Go to + > Split expense.
Enter amount > Next.
On confirmation page, hit CMD+Enter.
Verify the request is submitted.
Repeat step 2 and 3 > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any amount input using tab key > hit Enter
Verify the request is submitted.
Repeat step 2 and 3
Focus on any participant using up/down arrow key > hit Enter
Verify participant details page is opened.
Go back and Focus on any participant using up/down arrow key
After participant is focused use Tab key to focus amount input
Hit CMD+Enter/Enter > Verify the request is submitted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…plitting expense. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-06-15T02:48:16Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

mananjadhav · 2024-06-19T06:34:30Z

@Krishna2323 Can you confirm if this is resolved and it's ready for review?

Krishna2323 · 2024-06-19T15:06:30Z

@mananjadhav, no that's not resolved, still looking for a solution, I will explain the problem if I couldn't resolve it today.

Krishna2323 · 2024-06-21T07:53:34Z

@mananjadhav,

When the dropdown button has multiple option, we are not setting the buttonRef.

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 75 to 77 in 633e708

    
           ref={(ref) => { 
        
               caretButton.current = ref; 
        
           }}

But when we have simple button the buttonRef is correctly set and the press works?

App/src/components/ButtonWithDropdownMenu/index.tsx

Line 123 in 633e708

ref={buttonRef}

Why do we need the buttonRef? The buttonRef is required because SettlementButton uses KYCWall and in KYCWall we need the anchorRef (buttonRef) to open the options popover if there are multiple.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 164 to 165 in 633e708

    
           // Use event target as fallback if anchorRef is null for safety 
        
           const targetElement = anchorRef.current ?? (event?.currentTarget as HTMLDivElement);

Krishna2323 · 2024-06-21T08:43:16Z

@mananjadhav, Directly setting the ref like ref={buttonRef} would work but we also have to set caretButton.So I think we can use useEffect to set the caretButton.

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 75 to 77 in 633e708

    
           ref={(ref) => { 
        
               caretButton.current = ref; 
        
           }}

Setting the buttonRef like this won't work and it will throw an error, Cannot assign to 'current' because it is a read-only property.

 ref={(ref) => { 
     caretButton.current = ref; 
     buttonRef.current = ref;
 }}

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-06-21T08:46:02Z

Pls checkout 7c4f38e

mananjadhav · 2024-07-09T14:29:05Z

@Krishna2323 Using useEffect is fine. I wanted to confirm why did we disable the eslint rule?

mananjadhav · 2024-07-10T00:29:27Z

@Krishna2323 Is this ready for review? Can you please sync the latest main here?

Krishna2323 · 2024-07-10T00:31:13Z

@mananjadhav, this is ready, I will check the eslint rule in few moments.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-07-10T00:51:02Z

@mananjadhav, eslint rule removed.

mananjadhav · 2024-07-11T10:59:01Z

The code change looks fine to me. Will get this tested today.

mananjadhav · 2024-07-14T20:34:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-split-on-enter.mov

Android: mWeb Chrome

mweb-chrome-split-on-enter.mov

iOS: Native

ios-split-on-enter.mov

iOS: mWeb Safari

mweb-safari-split-on-enter.mov

MacOS: Chrome / Safari

web-split-on-enter-1.mov

web-split-on-enter-2.mov

MacOS: Desktop

desktop-split-on-enter-1.mov

mountiny

@Krishna2323 thanks, can you please add that one missing doc?

src/components/SettlementButton.tsx

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mountiny

Thanks! @mananjadhav @Krishna2323 lets be on a look out for regressions, these PRs are often tricky

OSBotify · 2024-07-19T22:11:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

rlinoz · 2024-07-22T20:35:45Z

Hey, this is preventing drop down buttons to work entirely

Screen.Recording.2024-07-22.at.17.31.32.mov

Reverting it here: #45964

OSBotify · 2024-07-23T08:35:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-24T00:15:44Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Krishna2323 · 2024-07-24T05:08:49Z

src/components/ButtonWithDropdownMenu/index.tsx

+        }
+        caretButton.current = buttonRef.current;
+    }, [buttonRef, options.length, shouldAlwaysShowDropdownMenu]);
+


@mananjadhav @mountiny, this code caused the regression, I have found the solution and will raise PR today. We need to use mergeRefs instead of this.

OSBotify · 2024-07-25T03:13:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-26T05:12:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Web - Split - Enter and CMD+Enter open user profile instead of s…

2312acf

…plitting expense. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner June 15, 2024 02:48

melvin-bot bot requested review from mananjadhav and removed request for a team June 15, 2024 02:48

Krishna2323 added 2 commits June 15, 2024 08:18

Merge branch 'main' into krishna2323/issue/41848

84db679

clean up repearted code.

990ccb2

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

fix buttonRef in ButtonWithDropdownMenu.

7c4f38e

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 mentioned this pull request Jun 26, 2024

[HOLD for payment 2024-08-27] [$250] Web - Split - Enter and CMD+Enter open user profile instead of splitting expense #41848

Closed

6 tasks

Merge branch 'Expensify:main' into krishna2323/issue/41848

8cf40a6

minor update.

dab66be

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav approved these changes Jul 16, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 16, 2024 21:53

Merge branch 'Expensify:main' into krishna2323/issue/41848

37c7e3b

mountiny assigned Krishna2323 Jul 19, 2024

mountiny previously approved these changes Jul 19, 2024

View reviewed changes

src/components/SettlementButton.tsx Show resolved Hide resolved

add docs for useKeyboardShortcuts.

a56bc41

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 dismissed mountiny’s stale review via a56bc41 July 19, 2024 00:53

mountiny approved these changes Jul 19, 2024

View reviewed changes

mountiny merged commit 331309f into Expensify:main Jul 19, 2024
10 checks passed

rlinoz mentioned this pull request Jul 22, 2024

Revert "fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense." #45964

Merged

50 tasks

github-actions bot mentioned this pull request Jul 23, 2024

Deploy Checklist: New Expensify 2024-07-23 #45991

Closed

95 tasks

Krishna2323 commented Jul 24, 2024

View reviewed changes

Krishna2323 mentioned this pull request Jul 26, 2024

fix: Split - Enter and CMD+Enter open user profile instead of splitting expense. #46278

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794

fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794

Krishna2323 commented Jun 15, 2024 •

edited

Loading

melvin-bot bot commented Jun 15, 2024

mananjadhav commented Jun 19, 2024

Krishna2323 commented Jun 19, 2024

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

mananjadhav commented Jul 9, 2024

mananjadhav commented Jul 10, 2024

Krishna2323 commented Jul 10, 2024

Krishna2323 commented Jul 10, 2024

mananjadhav commented Jul 11, 2024

mananjadhav commented Jul 14, 2024 •

edited

Loading

mountiny left a comment

mountiny left a comment

OSBotify commented Jul 19, 2024

rlinoz commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 24, 2024

Krishna2323 Jul 24, 2024

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794

fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794

Conversation

Krishna2323 commented Jun 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 15, 2024

mananjadhav commented Jun 19, 2024

Krishna2323 commented Jun 19, 2024

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

mananjadhav commented Jul 9, 2024

mananjadhav commented Jul 10, 2024

Krishna2323 commented Jul 10, 2024

Krishna2323 commented Jul 10, 2024

mananjadhav commented Jul 11, 2024

mananjadhav commented Jul 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 19, 2024

rlinoz commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 24, 2024

Krishna2323 Jul 24, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

Krishna2323 commented Jun 15, 2024 •

edited

Loading

mananjadhav commented Jul 14, 2024 •

edited

Loading