-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create usePaginatedReportActions hook #44412
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1fd8756
Create usePaginatedReportActions hook
roryabraham bf90268
Merge branch 'main' into Rory-DRYReportActionsSorting
roryabraham 7c42c89
fix test
roryabraham b6f8b76
Finish comment
roryabraham 3dc0a33
Verify new comment is on screen
roryabraham 8a43984
Merge branch 'main' into Rory-DRYReportActionsSorting
roryabraham eab1ab4
Remove isLinkedMessageAvailable local var
roryabraham 8289977
Merge branch 'main' into Rory-DRYReportActionsSorting
roryabraham f4e6750
fix bad boolean flip
roryabraham fd6cf82
Merge branch 'main' into Rory-DRYReportActionsSorting
roryabraham cf0de00
Merge branch 'main' into Rory-DRYReportActionsSorting
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import {useMemo} from 'react'; | ||
import {useOnyx} from 'react-native-onyx'; | ||
import * as ReportActionsUtils from '@libs/ReportActionsUtils'; | ||
import ONYXKEYS from '@src/ONYXKEYS'; | ||
|
||
/** | ||
* Get the longest continuous chunk of reportActions including the linked reportAction. If not linking to a specific action, returns the continuous chunk of newest reportActions. | ||
*/ | ||
function usePaginatedReportActions(reportID?: string, reportActionID?: string) { | ||
// Use `||` instead of `??` to handle empty string. | ||
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
const reportIDWithDefault = reportID || '-1'; | ||
const [sortedAllReportActions = []] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportIDWithDefault}`, { | ||
canEvict: false, | ||
selector: (allReportActions) => ReportActionsUtils.getSortedReportActionsForDisplay(allReportActions, true), | ||
}); | ||
|
||
const reportActions = useMemo(() => { | ||
if (!sortedAllReportActions.length) { | ||
return []; | ||
} | ||
return ReportActionsUtils.getContinuousReportActionChain(sortedAllReportActions, reportActionID); | ||
}, [reportActionID, sortedAllReportActions]); | ||
|
||
const linkedAction = useMemo(() => sortedAllReportActions.find((obj) => String(obj.reportActionID) === String(reportActionID)), [reportActionID, sortedAllReportActions]); | ||
|
||
return { | ||
reportActions, | ||
linkedAction, | ||
}; | ||
} | ||
|
||
export default usePaginatedReportActions; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we even have this rule? This is like the 3rd time I've seen it dismissed today.