-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Classic > Xero help docs #45971
Conversation
A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️ |
Already see some changes I need to make 🤦♀️ will update that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the build and needed to make some changes. Will review the new build and reassess.
Okay reviewed the new build and things look good except for one annoying thing that I can't figure out. When I have a bulleted list and the list steps back from 3 indents to 2 indents, an extra return is added. I tried to correct this thinking I'd put an extra one in myself but I didn't. @dangrous do you know how I can fix this? |
Hey @strepanier03! That's not something you did, don't worry! It's known - #44107 - so we can go ahead and push this, and that will get settled afterwards. |
Let me know if this is otherwise ready to review and we can assign @rushatgabhane and I can do a final check |
@dangrous this is ready. I've done a full review on my end and made any tweaks that were needed. This is ready for you to move forward. Also, thank you for the letting me know about the returns, it was driving me bonkers and I couldn't figure out how I was doing it lmao. I appreciate knowing I'm not going crazy yet. |
@rushatgabhane assigned you if you want to take a quick look and checklist! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.12-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.13-0 🚀
|
Details
Coming from https://github.com/Expensify/Expensify/issues/412479.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop