Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Selection Mode #46096

Conversation

filip-solecki
Copy link
Contributor

@filip-solecki filip-solecki commented Jul 24, 2024

Details

This PR add new Selection Mode on small devices on a few pages listed in the main issue. It is already implemented on the Search page but has to be refactored to add possibility to use it in tho whole app.

Fixed Issues

$ #45451
PROPOSAL:

Tests

Workspace Members 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Members (as an admin) 4. Add a few members if you are alone 5. Long press on some item 6. Chose "Select" 7. Select and unselect options and test some bulk action
Workspace Distance Rates 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Distance Rates (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few distance rates if there is only one rate 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Categories 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Categories (as an admin) 4. Turn it on in `More features` if not enabled 5. Long press on some item 6. Chose "Select" 7. Select and unselect options and test some bulk action
Workspace multi level Tags 1. Log in to OD 2. Go to Workspace settings 3. Go to Tags and enable it if not enabled 4. Enable `People must tag expenses` and `Use multiple level of tags` 5. Import some multi level Tags (eh. [this](https://github.com/Expensify/App/files/15195760/Independent%2Bwithout%2BGL%2Bcodes%2Bformat.csv) ) 6. Go to ND 7. Go to the same Workspace and Tags page 8. You should not be able to select any Tag on main page 9. Go to Tag details 10. You'll see Tags inside 11. Long press on some item 12. Chose "Select" 13. Select and unselect options and test some bulk action
Workspace single level Tags 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Tags (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few Tags 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Taxes 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Taxes (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few tax rates 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Report Fields 1. Change `canUseReportFieldsFeature` in `permissions.ts` to return true 2. Log in to the app 3. Go to existing Workspace or create new 4. Go to Report Fields (as an admin) 5. Turn it on in `More features` if not enabled 6. Add a few items 7. Long press on some item 8. Chose "Select" 9. Select and unselect options and test some bulk action
Workspace Report Fields - Add list type report 1. Change `canUseReportFieldsFeature` in `permissions.ts` to return true 2. Log in to the app 3. Go to existing Workspace or create new 4. Go to Report Fields (as an admin) 5. Turn it on in `More features` if not enabled 6. Click "Add field" 7. Fill required fields 8. Chose "List" type 9. Chose "List values" 10. Add a few items 11. Long press on some item 12. Chose "Select" 13. Select and unselect options and test some bulk action
Group chat -> Members 1. Log in to the app 2. Go to existing group chat (if you don't have any go to point 3 otherwise go to point 6) 3. Click `+` button 4. Chose `Start chat` 5. Add a few people to the chat 6. Go to chat details 7. Go to members 8. Long press on some item 9. Chose "Select" 11. Select and unselect options and test some bulk action
Search 1. Log in to the app (use account with existing transactions or create a few new) 2. Go to Search Tab (from bottom tab) 3. Use small screen width or mobile device 4. Long press some item 5. Chose "Select" option 6. Select and unselect options and do some bulk action
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Workspace Members 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Members (as an admin) 4. Add a few members if you are alone 5. Long press on some item 6. Chose "Select" 7. Select and unselect options and test some bulk action
Workspace Distance Rates 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Distance Rates (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few distance rates if there is only one rate 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Categories 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Categories (as an admin) 4. Turn it on in `More features` if not enabled 5. Long press on some item 6. Chose "Select" 7. Select and unselect options and test some bulk action
Workspace multi level Tags 1. Log in to OD 2. Go to Workspace settings 3. Go to Tags and enable it if not enabled 4. Enable `People must tag expenses` and `Use multiple level of tags` 5. Import some multi level Tags (eh. [this](https://github.com/Expensify/App/files/15195760/Independent%2Bwithout%2BGL%2Bcodes%2Bformat.csv) ) 6. Go to ND 7. Go to the same Workspace and Tags page 8. You should not be able to select any Tag on main page 9. Go to Tag details 10. You'll see Tags inside 12. Long press on some item 13. Chose "Select" 14. Select and unselect options and test some bulk action
Workspace single level Tags 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Tags (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few Tags 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Taxes 1. Log in to the app 2. Go to existing Workspace or create new 3. Go to Taxes (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few tax rates 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Report Fields 1. Log in to the app with an account that has Report Fields beta enabled 2. Go to existing Workspace or create new 3. Go to Report Fields (as an admin) 4. Turn it on in `More features` if not enabled 5. Add a few items 6. Long press on some item 7. Chose "Select" 8. Select and unselect options and test some bulk action
Workspace Report Fields - Add list type report 1. Use an account that has Report Fields beta enabled 2. Log in to the app 3. Go to existing Workspace or create new 4. Go to Report Fields (as an admin) 5. Turn it on in `More features` if not enabled 6. Click "Add field" 7. Fill required fields 8. Chose "List" type 9. Chose "List values" 10. Add a few items 11. Long press on some item 12. Chose "Select" 13. Select and unselect options and test some bulk action
Group chat -> Members 1. Log in to the app 2. Go to existing group chat (if you don't have any go to point 3 otherwise go to point 6) 3. Click `+` button 4. Chose `Start chat` 5. Add a few people to the chat 6. Go to chat details 7. Go to members 8. Long press on some item 9. Chose "Select" 10. Select and unselect options and test some bulk action
Search 1. Log in to the app (use account with existing transactions or create a few new) 2. Go to Search Tab (from bottom tab) 3. Use small screen width or mobile device 4. Long press some item 5. Chose "Select" option 6. Select and unselect options and do some bulk action
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Workspace Members
Desktop_Workspace-Members.mov
Workspace Distance Rates
Web_Distance-rates.mov
Workspace Categories
iOS_Categories.mp4
Workspace multi level Tags
Web_Multi_Tags.mov
Workspace single level Tags
Web_Tags.mov
Workspace Taxes
Desktop_Taxes.mov
Workspace Report Fields
Web_ReportFields.mov
Group chat -> Members [Android_Group-members.webm](https://github.com/user-attachments/assets/cf3aafbf-baf2-4f5a-973e-17de9ff96ab4)
Search [Android_Web_Search.webm](https://github.com/user-attachments/assets/a709d5e7-2cfb-4796-b724-231c2d5eb644)

Copy link
Contributor

@zfurtak zfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@filip-solecki filip-solecki marked this pull request as ready for review July 25, 2024 10:22
@filip-solecki filip-solecki requested a review from a team as a code owner July 25, 2024 10:22
@melvin-bot melvin-bot bot removed the request for review from a team July 25, 2024 10:22
Copy link

melvin-bot bot commented Jul 25, 2024

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from ikevin127 July 25, 2024 10:22
@filip-solecki
Copy link
Contributor Author

@ikevin127 it's all yours!

@ikevin127
Copy link
Contributor

ikevin127 commented Jul 25, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native *
android.mp4
Android: mWeb Chrome *
android-mweb.webm
iOS: Native *
ios.MP4
iOS: mWeb Safari *
ios-mweb.mp4
MacOS: Chrome / Safari
MacOS: Desktop

@ikevin127
Copy link
Contributor

ikevin127 commented Jul 25, 2024

@filip-solecki Completed the checklist, overall functionality looks great - good job on this one!

⚠️ However, while testing I found 3 issues. Here they are in the order I found them:

    • New mobile selection mode is missing in Report Fields > [+] Add field > Type: List > List values

      Note: Happens on all platforms (native and mWeb).

      Video
      android-reportFields-missing.webm
    • Search - Select UI Glitch: ✅ Remains in card after going back from Select multiple

      Note: Happens on all platforms (native and mWeb).

      Video
      android-search-issue.webm
    • Selected items modal backdrop non-existent on mWeb

      Note: Happens only on mWeb - both Android / iOS - Chrome and Safari.

      Video
      android-mweb-backdrop-issue.webm

Based on the #45451 issue, I think these 3 issues should be addressed here as they seem to be part of the scope. Once the issues are addressed and conflicts are solved I'll re-test to confirm they are fixed then will Approve if everything looks good.

@ikevin127
Copy link
Contributor

@filip-solecki Regarding issue number 3 with the modal backdrop on mWeb, I just checked on staging and it does not happen.

But it does happen on latest main local dev, so I'm assuming it has something to do with StrictMode.

Just to check it off the list as NAB I would go to CONFIG and set USE_REACT_STRICT_MODE to false - if the issue goes away then it means it only looks broken on local dev - therefore we can check it off the list.

Possible to have a similar thing with issue number 2 - so I'd check out the StrictMode thing first with that one as well.

@filip-solecki
Copy link
Contributor Author

@jasperhuangg - resolved

@filip-solecki
Copy link
Contributor Author

@ikevin127 Please check my latest commit - I decided to move turning on selection mode logic to SelectionListWithModal to avoid recreating this logic in every component

@ikevin127
Copy link
Contributor

LGTM - Ready to Merge 🚀

cc @jasperhuangg

@jasperhuangg jasperhuangg merged commit d4104a7 into Expensify:main Jul 30, 2024
14 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@ikevin127
Copy link
Contributor

@filip-solecki I decided to do a double-check again and I noticed an issue on the Search page:

  • once entered in select mode, as long as there's at least 1 item selected -> we cannot go back (exit select mode) using [< Select multiple] button
  • the go back [< Select multiple] button only works as expected if no items are selected (checked), see video below

This happens with StrictMode off as well, so it's not because of StrictMode. It also happens on all platforms (mWeb and Native). Note: It's possible that this happened after the push of commit 7a0e5a6.

@jasperhuangg Maybe there's still time to push a follow-up fix before this gets deployed and the regression is reported.

iOS iOS-mWeb
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-30.at.15.51.18.mp4
ios-mweb.mp4

@filip-solecki
Copy link
Contributor Author

Hmm, for sure it is fixed in this PR and imo it's better to focus on that PR and merge it quickly as fixing it in this PR might be a little bit tricky, WDYT?

@ikevin127
Copy link
Contributor

ikevin127 commented Jul 31, 2024

@filip-solecki Not sure what PR you are referencing - the issue I just found was found after this PR was merged by checking-out this PRs branch.

As I referenced in my previous comment: the issue wasn't present before your latest commit 7a0e5a6 so I'm assuming that's where things went south.

I just wanted to double-check with you and let people know - maybe we can fix the issue before this PR is deployed to staging and a regression will for sure arise.

Nevermind, I got it now - the issue mentioned above will be fixed in PR #46406.

That would be it - thank you!

@filip-solecki
Copy link
Contributor Author

filip-solecki commented Jul 31, 2024

Sorry, pasted wrong link - I mean this PR

@filip-solecki
Copy link
Contributor Author

I've asked @rushatgabhane for prioritizing review on mentioned PR to avoid regression here

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.15-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@filip-solecki filip-solecki mentioned this pull request Aug 2, 2024
50 tasks
@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 7, 2024

Hey!
Looks like this PR breaks the selection mode for the report field's list values. This new line changed the condition.

if ((isSmallScreenWidth && selectionMode?.isEnabled) ?? selectedValuesArray.length > 0) {

The correct one is:

if ((isSmallScreenWidth ? selectionMode?.isEnabled : true) && selectedValuesArray.length > 0) {
Video
Bug.mp4

cc @filip-solecki @ikevin127 @jasperhuangg @zfurtak

@jasperhuangg
Copy link
Contributor

@rezkiy37 Thanks for investigating! Looks like we're aware of that and will address that in the the fix PR: #46698 (comment)

@ikevin127
Copy link
Contributor

Issue was fixed in PR #46698, commit 6e6edea, here's the proof. Next, we're looking at merging the PR 🚀

@jayeshmangwani
Copy link
Contributor

Coming from this Issue #46619, we missed to disabling the dropdown button on mobile devices when no data is selected we fixed it in this PR , more context for the solution on this Proposal #46619 (comment)

@getusha
Copy link
Contributor

getusha commented Sep 29, 2024

Coming from #46620, we missed disabling a selection on disabled selection items on mobile devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants