-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: integration icons next to export buttons #47812
base: main
Are you sure you want to change the base?
Conversation
waiting for a reply on #46981 (comment) |
@akinwale PR is ready for your review! |
@neonbhai Please fix merge conflicts. |
fixed! cc: @akinwale |
@neonbhai The Jest unit tests, lint and TypeScript Check steps are failing. Please check this. |
ah, apologies. Fixed and retested @akinwale |
@akinwale friendly bump for review |
Can we make the icons the same size across both? I see I visually prefer the 32, though I seem to remember us choosing the 40 in some other PR. Keen to hear what @dannymcclain thinks though |
I was waiting to get Sage Intaact credentials for testing. I should be able to review today or tomorrow. |
Yeah that looks more correct to me. Let's do what @dannymcclain suggests |
@neonbhai Please fix merge conflicts and confirm latest design comments. Thanks. |
Details
Fixed Issues
$ #46981
PROPOSAL: #46981 (comment)
Tests
Precondition:
Offline tests
Same as Tests step
QA Steps
Same as Tests step
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop