-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling when user gives wrong credentials. #48001
Add error handling when user gives wrong credentials. #48001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I'll review this later today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @SzymczakJ Can you merge main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird, I thought we already deleted these files a while ago. Can you merge main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged main, I think there was some strange merge conflict a while ago and somebody didn't notice it.
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-04.at.18.22.26.movAndroid: mWeb ChromeScreen.Recording.2024-09-04.at.10.22.48.moviOS: Native// build issue Screen.Recording.2024-09-04.at.18.18.08.moviOS: mWeb SafariScreen.Recording.2024-09-04.at.10.14.47.movMacOS: Chrome / SafariScreen.Recording.2024-09-04.at.09.48.24.movMacOS: DesktopScreen.Recording.2024-09-04.at.10.04.43.mov |
@yuwenmemon can you trigger a build? I want to test it on my android, I can't build native android for now. |
If you're having problems with building android and error is something like: "... missing sdkManager package ..." try installing it with these instructions. Everybody from SWM recently got this error. |
Awesome! Do you guys have issue with ios native? I've been stuck for few days :/ |
iOS was also problematic 😃. For me the solution was to remove node modules, ios/Pods folder and ios/build folder and reinstall + rebuild everything. |
On Android, I added packName to |
@SzymczakJ You have conflicts. @hungvu193 Looks like you don't need an ad-hoc build, correct? |
Yes. I was able to run native code so no action needed |
Solved conflicts @yuwenmemon |
Damn, again some conflicts 😖 |
Solved them again |
@@ -636,6 +636,8 @@ const CONST = { | |||
EXPENSIFY_PACKAGE_FOR_SAGE_INTACCT_FILE_NAME: 'ExpensifyPackageForSageIntacct', | |||
SAGE_INTACCT_INSTRUCTIONS: 'https://help.expensify.com/articles/expensify-classic/integrations/accounting-integrations/Sage-Intacct', | |||
HOW_TO_CONNECT_TO_SAGE_INTACCT: 'https://help.expensify.com/articles/expensify-classic/integrations/accounting-integrations/Sage-Intacct#how-to-connect-to-sage-intacct', | |||
SAGE_INTACCT_HELP_LINK: | |||
"https://help.expensify.com/articles/expensify-classic/connections/sage-intacct/Sage-Intacct-Troubleshooting#:~:text=First%20make%20sure%20that%20you,your%20company's%20Web%20Services%20authorizations.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This period at the end shouldn't be there but it doesn't break the link for me, so NAB
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.30-0 🚀
|
Details
This PR adds error handling when user gives wrong credentials to Sage Intacct.
Fixed Issues
$ #44669
$ #47499
PROPOSAL:
Tests
Try reentering credentials.
Verify that after connecting with correct credentials Sage Intacct connects successfully.
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
![Screenshot 2024-09-03 at 00 21 30](https://github.com/user-attachments/assets/ac5379b9-6d45-4e91-ad60-2aad7d1c9668)iOS: mWeb Safari
![Screenshot 2024-09-03 at 00 22 37](https://github.com/user-attachments/assets/aca03587-b9f2-4b1e-bcdb-e1b94b696979)MacOS: Chrome / Safari
![Screenshot 2024-09-03 at 00 10 35](https://github.com/user-attachments/assets/4baf79ba-edae-486c-8105-aba70a1e06d2)MacOS: Desktop