Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents three dot menu from showing up in members page if not policy admin #49664

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Prevents three dot menu from showing up in members page if not policy admin #49664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ad89b
not showing three dot menu in members page if not admin
rlinoz Sep 24, 2024
a752d0c
adding isPolicyAdmin to memo
rlinoz Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pages/workspace/WorkspaceMembersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,10 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson
};

const threeDotsMenuItems = useMemo(() => {
if (!isPolicyAdmin) {
return [];
}

const menuItems = [
{
icon: Expensicons.Table,
Expand Down Expand Up @@ -596,7 +600,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson
];

return menuItems;
}, [policyID, translate, isOffline]);
}, [policyID, translate, isOffline, isPolicyAdmin]);

const selectionModeHeader = selectionMode?.isEnabled && shouldUseNarrowLayout;

Expand All @@ -610,7 +614,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson
testID={WorkspaceMembersPage.displayName}
shouldShowLoading={false}
shouldShowOfflineIndicatorInWideScreen
shouldShowThreeDotsButton
shouldShowThreeDotsButton={isPolicyAdmin}
threeDotsMenuItems={threeDotsMenuItems}
threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(windowWidth)}
shouldShowNonAdmin
Expand Down
Loading