-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put category and tag approvers behind a new beta #49811
base: main
Are you sure you want to change the base?
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
To my future internal reviewer whenever you get assigned... I'm probably already OOO for the week, but if you can make sure this PR gets merged while I'm gone would be great. cc @JmillsExpensify can maybe find me a replacement if that trick fails :) This is one of the last things blocking us from OldDot Rules Migration roll out 🎉 |
@marcaaron I can see it's held on Web PR, but does this need C+ review? |
Yes the beta will be added whenever it's added, but the test steps are the same. |
Cool will review and test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code and I think I'll start with the checklist despite being on Hold for Web? We're only disabling the feature right?
Web-E PR is on prod now! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
The beta should be live now. I will fix the conflicts. @mananjadhav I see you started the checklist, but did not complete it. Let me know if you're blocked on anything. |
Prettier issue should be resolved soon https://expensify.slack.com/archives/C03V9A4TB/p1728339612502319?thread_ts=1728334029.063939&cid=C03V9A4TB |
The app was running very slow and delayed yesterday. I'll finish the checklist today. |
Details
cc @JmillsExpensify puts the Category and Tag approver parts of OldDot Rules Migration behind a new beta.
Fixed Issues (Part 2)
$ https://github.com/Expensify/Expensify/issues/431466
Tests
workspaceRules
beta enabled, workflows, approvals, and thecategoryAndTagApprovers
beta disabled (on dev apply the diff below)Offline tests
❌
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop