Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add the workspace name to the title of the workspace chats" #50230

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Oct 4, 2024

Straight revert

Discussing here that we should plan out the various edge cases more https://expensify.slack.com/archives/C07HPDRELLD/p1727822614355529

Reverts #49911

@mountiny mountiny self-assigned this Oct 4, 2024
@mountiny mountiny requested a review from a team as a code owner October 4, 2024 11:53
@melvin-bot melvin-bot bot requested a review from arosiclair October 4, 2024 11:53
Copy link

melvin-bot bot commented Oct 4, 2024

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 4, 2024 11:53
@Gonals Gonals self-requested a review October 4, 2024 12:16
@mountiny mountiny merged commit 5b6886a into main Oct 4, 2024
14 of 16 checks passed
@mountiny mountiny deleted the revert-49911-issue-49624 branch October 4, 2024 12:16
@melvin-bot melvin-bot bot added the Emergency label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Oct 4, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Oct 4, 2024

Straight revert so skipping the checklists

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.45-1 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants