-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Request conflict resolution for OpenApp #50258
base: main
Are you sure you want to change the base?
[NoQA] Request conflict resolution for OpenApp #50258
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mountiny not sure if you have to review this one |
@gedu yes, can you please leave some testing steps to ensure the resolver works? @shubham1206agra what is your ETA for a review? |
import type OnyxRequest from '@src/types/onyx/Request'; | ||
import type {ConflictActionData} from '@src/types/onyx/Request'; | ||
|
||
function resolveDuplicationConflictAction(persistedRequests: OnyxRequest[], commandToFind: WriteCommand): ConflictActionData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a plain English explanation for this method and why it exists so it's easier to follow for other devs? Thanks!
expect(PersistedRequests.getAll().length).toBe(0); | ||
}); | ||
|
||
test('ReconnectApp should replace same requests from the queue', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test('ReconnectApp should replace same requests from the queue', async () => { | |
test('OpenApp should replace same requests from the queue', async () => { |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Details
Adding similar resolver for OpenApp like ReconnectApp, to avoid duplicated OpenApp requests
Fixed Issues
$ #50076
PROPOSAL: -
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop