Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Updated selected transaction If getting new updates" #50322

Conversation

cretadn22
Copy link
Contributor

Reverts #49829 to Fix #50286

@cretadn22 cretadn22 requested a review from a team as a code owner October 7, 2024 03:38
@cretadn22 cretadn22 marked this pull request as draft October 7, 2024 03:38
@melvin-bot melvin-bot bot requested a review from marcaaron October 7, 2024 03:38
Copy link

melvin-bot bot commented Oct 7, 2024

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 7, 2024 03:38
@cretadn22 cretadn22 marked this pull request as ready for review October 7, 2024 03:39
@cretadn22
Copy link
Contributor Author

cc @luacmartins @jjcoffee

@jjcoffee
Copy link
Contributor

jjcoffee commented Oct 7, 2024

@cretadn22 Why the revert? Can't we find a fix?

@cretadn22
Copy link
Contributor Author

I am working on a fix, the reverted PR is created in case we need to fix asap

@thienlnam
Copy link
Contributor

@cretadn22 How is the fix coming along? I'm planning on deploying within a couple hours so if we could get something merged by then that would be ideal

@cretadn22
Copy link
Contributor Author

The fix has been implemented in this PR: #50347

@cretadn22
Copy link
Contributor Author

@thienlnam If @jjcoffee can review #50347 soon, I'll go ahead and close this PR.

@cretadn22 cretadn22 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOLD for payment 2024-10-14] Search - Selected expense does not remain selected, gets auto deselected
3 participants