[HOLD] Update code to use early return wherever appropriate #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a ton of scary early returns roll back a few that seems wrong undo a couple else if that seem wrong
marcaaron
force-pushed
the
marcaaron-earlyReturn
branch
from
1e1083f
to
11e30ee
Compare
|
Actually gonna throw a hold on this one and put it back into draft. I feel confident about the other style fixes I'm making but this one is slightly riskier since it modifies control logic in a lot of places. |
marcaaron
changed the title
|
Decided to tackle this in #6174 instead. Wrote a custom linter for finding these usages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Added to the style guide when to identify that early returns should be preferred. It's something that we ask for a lot and is rarely explained.
Fixed Issues
$ #5995
Tests / QA Steps
All of these changes should be syntax and shouldn't have any bearing on the app behavior.
Therefore, we just need to run regular regressions.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android