Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropdown arrow to be clicked on select inputs #6329

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

luacmartins
Copy link
Contributor

Details

Allows users to open dropdown by clicking over the dropdown icon.

Fixed Issues

$ #6324

Tests

  1. Login to NewDot
  2. Select any Workspace
  3. Click on Add bank account and Connect manually
  4. Enter 011401533 and 1111222233331111 for routing and account number, respectively.
  5. On the company step, verify that clicking on the dropdown arrow icon in the select inputs opens the input.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins requested a review from a team as a code owner November 16, 2021 18:27
@luacmartins luacmartins self-assigned this Nov 16, 2021
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team November 16, 2021 18:27
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh a "css" solution nice find 😄. Thanks for putting up the video as proof.

@TomatoToaster TomatoToaster merged commit e0be29d into main Nov 16, 2021
@TomatoToaster TomatoToaster deleted the cmartins-pickerIcon branch November 16, 2021 19:29
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @TomatoToaster in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants