-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific error messages for additional details page #9495
Add specific error messages for additional details page #9495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and also test well. One request, @thesahindia Is it possible to get a minDate on the date picker?
Also can you check mark every item on the list in GH body (even if they don't apply) to confirm that we've checked those.
@@ -327,18 +369,18 @@ class AdditionalDetailsStep extends React.Component { | |||
<DatePicker | |||
containerStyles={[styles.mt4]} | |||
label={this.props.translate(this.fieldNameTranslationKeys.dob)} | |||
onInputChange={val => this.clearErrorAndSetValue('dob', val)} | |||
onInputChange={val => this.clearDateErrorsAndSetValue(val)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this again and it shows Must be over 18
Oh NVM, you have added a future date that's why the error is different.
I get a different date format and unable to move forward.
Yeah we have a different format on native.
We have maximumDate which stops user from choosing future dates but it only works for Web/Desktop
Done. |
No I meant |
I am not really sure but I guess we can do that. Also can you please provide some context about how we wanna use it? |
You're right this could be out of the scope of this issue. I thought if its a prop available we can just set it. |
@AndrewGable Review done 🎀 👀 🎀 C+ reviewed
|
Nice work on filling out the checklists! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @AndrewGable in version: 1.1.83-1 🚀
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
@mananjadhav @thesahindia do you think #10240 is a regression from this PR? |
Details
This PR will add specific error message for different fields at additional details page.
Fixed Issues
$ #9247
Tests
EnablePaymentsPage
to render the additional details page(now you can just tap on your avatar and it will render the additional details page)App/src/libs/Navigation/AppNavigator/ModalStackNavigators.js
Line 179 in 2ec4a1c
Please enter a valid xyz
Must be over 18 years old
)PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Please enter a valid xyz
Must be over 18 years old
)Screenshots
Web
Mobile Web
Desktop
iOS
Android