Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use actions dir for setupNode action #9862

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jul 12, 2022

Details

Following-up on #9815 to fix some paths.

Fixed Issues

$ n/a

Tests

  1. Merge this PR
  2. Tests and lint will run and should pass

@roryabraham roryabraham requested a review from a team as a code owner July 12, 2022 21:22
@roryabraham roryabraham self-assigned this Jul 12, 2022
@AndrewGable AndrewGable requested review from AndrewGable and removed request for a team July 12, 2022 21:22
@melvin-bot melvin-bot bot requested a review from jasperhuangg July 12, 2022 21:22
AndrewGable
AndrewGable previously approved these changes Jul 12, 2022
@roryabraham roryabraham merged commit 90c4629 into main Jul 12, 2022
@roryabraham roryabraham deleted the Rory-FixActionPath branch July 12, 2022 21:43
@melvin-bot melvin-bot bot added the Emergency label Jul 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2022

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@AndrewGable
Copy link
Contributor

Tests will fail until we merge because they use the code on main. Merging to fix tests!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants