Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] Revert "[No QA] Make GitUtils use spawn/stream instead of execSync/buffer" #9900

Closed
wants to merge 1 commit into from
Closed

[HOLD] Revert "[No QA] Make GitUtils use spawn/stream instead of execSync/buffer" #9900

wants to merge 1 commit into from

Conversation

roryabraham
Copy link
Contributor

Reverts #9891

@roryabraham roryabraham requested a review from a team as a code owner July 13, 2022 23:27
@roryabraham roryabraham self-assigned this Jul 13, 2022
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team July 13, 2022 23:28
@roryabraham roryabraham changed the title Revert "[No QA] Make GitUtils use spawn/stream instead of execSync/buffer" [HOLD] Revert "[No QA] Make GitUtils use spawn/stream instead of execSync/buffer" Jul 13, 2022
@roryabraham
Copy link
Contributor Author

Actually going to just close this, because I'm not sure if the original changes are necessary or not. They work, just are a bit more complex/over-engineered than what we had before. Because the git logs are still insane, as mentioned in this comment, it seems like the original changes might still be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyevans amyevans Awaiting requested review from amyevans

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roryabraham