Resolve #172, Enable HTTP Proxy Support for iControlRESTTokenAuth Object
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: Fixes F5Networks#172 Problem: The `proxies` attribute is available on the `iControlRESTSession` object, however it does not get passed to the `iControlRESTTokenAuth` object. As a result, if all communication with a BigIP device needs to take place via a Proxy, authentication will fail and timeout. Analysis: I added `proxies` as a Kwarg on the `iControlRESTTokenAuth` object. I then passed that argument in from the `iControlRESTSession` object instantiations of the `iControlRESTTokenAuth` object. I then added `proxies=self.proxies` to the two instances of `requests.<verb>` in the `iControlRESTTokenAuth` object. Tests: I am unable to run the tests as listed in the documentation as even in 1.0 branch, `py.test --cov ./ --cov-report=html` returns: `argparse.ArgumentError: argument --bigip: conflicting option string: --bigip` I did successfully test with and without proxies, by installing my fork/branch and testing against a live BigIP With Proxies: In [1]: paste from f5.bigip import ManagementRoot from getpass import getpass password = getpass() user = "test_user" host = "test_f5.local" mah_f5 = ManagementRoot(hostname=host, username=user, password=password, proxies={"https": "socks5://127.0.0.1:8000"}, auth_provider="tmos") mah_f5.tmos_version ## -- End pasted text -- Password: Out[1]: '14.1.2.3' Without Proxies: In [1]: paste from f5.bigip import ManagementRoot from getpass import getpass password = getpass() user = "test_user" host = "localhost" port = 30002 mah_f5 = ManagementRoot(hostname=host, port=port, username=user, password=password, auth_provider="tmos") mah_f5.tmos_version ## -- End pasted text -- Password: Out[1]: '14.1.2.3'
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jasonrahm
What issues does this address?
Fixes #172
What's this change do?
Enable HTTP Proxy support in the
iControlRESTTokenAuthobject by passing theproxiesfromiControlRESTSessionobject down into it, and applying it to therequest.<verb>calls that take place in that module.Where should the reviewer start?
icontrol/authtoken.py, line 58, then follow it through the
self.proxiesvalue in that object.icontrol/session.py, line 432, then follow where
self.proxieswas passed as an argument to the underlying token/auth object.Any background context?
This change is required for full HTTP Proxy functionality.
Otherwise, while the outer
requests.Sessionobject iniControlRESTSessiondoes attempt to utilize the proxies provided to it, the inner token acquisition and validation methods iniControlRESTTokenAuthfail as they do not know about the proxy.