Skip test if adios2 python module built without MPI. #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhale
added
backport?
drew-parsons
requested changes
Jul 17, 2024
|
@drew-parsons We have decided that this test will only run if the user supplies |
jorgensd
approved these changes
Sep 6, 2024
drew-parsons
approved these changes
Sep 6, 2024
garth-wells
requested changes
Sep 6, 2024
|
@garth-wells are you happy with the simplification? I can't get it to auto-merge without "force-dismissing" your review, which seems rather rude;) |
garth-wells
approved these changes
Sep 10, 2024
schnellerhase
pushed a commit
to schnellerhase/dolfinx
that referenced
this pull request
Sep 11, 2024
* This test only works if ADIOS2 was built with MPI. * Require MPI ADIOS2 build during configuration. * Reformat ruff. * Require adios2.10 for given test * Ruff * Simplify * Add back skip --------- Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk> Co-authored-by: jorgensd <dokken92@gmail.com> Co-authored-by: Jørgen S. Dokken <dokken@simula.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would also be good to not build against ADIOS2 if it wasn't built against MPI...