Improve check for facet->cell connectivity #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdean
approved these changes
Jun 25, 2024
garth-wells
reviewed
Jun 26, 2024
schnellerhase
pushed a commit
to schnellerhase/dolfinx
that referenced
this pull request
Jul 1, 2024
* Improve check * Update utils.cpp
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
…trieving complete boundary (#3283) * Introduce optionally empty marker for boundary entities * Adapt to optional boundary marker * Make use of simplifications in python code * Make use of simplifications in cpp code * Add xfail for now (#3284) * Data independent form compilation for Python interface (#3263) * Create mesh independent form compilator for Python interface * Ruff formatting * Mypy * Parameterize test over all dtypes * Ruff format * Fix compile options handling * Fix coeff and constant name mapping * Ruff * Remove extra definition of basix element and check that mesh c_el is consistent * Add support for linear and bilinear forms * Fix typo * Apply suggestions from code review Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> * Apply suggestions from code review Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Igor Baratta <igorbaratta@gmail.com> * Apply suggestions from code review * Add documentation and default scalar type --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Igor Baratta <igorbaratta@gmail.com> * Bump docker/build-push-action from 5 to 6 (#3279) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v5...v6) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve check for facet->cell connectivity (#3281) * Improve check * Update utils.cpp * Revert optional and use * Ruff * Typo * another * Fix biharmonic * Fix python biharmonic * Fix python demo hdg * last? * fix test fem pipeline * fem pipeline the last? * Remove workarounds following upstream updates for CI (#3289) * Remove temporary workarounds * Use dict comprehension * Export missing compile time constants to python (#3285) Co-authored-by: papel <xDNdnQoyTcrrMdWCVZft4YLqkaRWnRb@protonmail.com> * Update python/demo/demo_biharmonic.py Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com> * Apply suggestions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com> Co-authored-by: Igor Baratta <igorbaratta@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: papel <xDNdnQoyTcrrMdWCVZft4YLqkaRWnRb@protonmail.com>
schnellerhase
pushed a commit
to schnellerhase/dolfinx
that referenced
this pull request
Sep 11, 2024
* Improve check * Update utils.cpp
schnellerhase
added a commit
to schnellerhase/dolfinx
that referenced
this pull request
Sep 11, 2024
…trieving complete boundary (FEniCS#3283) * Introduce optionally empty marker for boundary entities * Adapt to optional boundary marker * Make use of simplifications in python code * Make use of simplifications in cpp code * Add xfail for now (FEniCS#3284) * Data independent form compilation for Python interface (FEniCS#3263) * Create mesh independent form compilator for Python interface * Ruff formatting * Mypy * Parameterize test over all dtypes * Ruff format * Fix compile options handling * Fix coeff and constant name mapping * Ruff * Remove extra definition of basix element and check that mesh c_el is consistent * Add support for linear and bilinear forms * Fix typo * Apply suggestions from code review Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> * Apply suggestions from code review Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Igor Baratta <igorbaratta@gmail.com> * Apply suggestions from code review * Add documentation and default scalar type --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Igor Baratta <igorbaratta@gmail.com> * Bump docker/build-push-action from 5 to 6 (FEniCS#3279) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v5...v6) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve check for facet->cell connectivity (FEniCS#3281) * Improve check * Update utils.cpp * Revert optional and use * Ruff * Typo * another * Fix biharmonic * Fix python biharmonic * Fix python demo hdg * last? * fix test fem pipeline * fem pipeline the last? * Remove workarounds following upstream updates for CI (FEniCS#3289) * Remove temporary workarounds * Use dict comprehension * Export missing compile time constants to python (FEniCS#3285) Co-authored-by: papel <xDNdnQoyTcrrMdWCVZft4YLqkaRWnRb@protonmail.com> * Update python/demo/demo_biharmonic.py Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com> * Apply suggestions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com> Co-authored-by: Igor Baratta <igorbaratta@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: papel <xDNdnQoyTcrrMdWCVZft4YLqkaRWnRb@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
exterior_facet_indices()only checks that the facet index map exists, which is insufficient.