-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::optional
to reduce code duplication in boundary condition setting
#3434
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
e789938
Use std::optional in bc setting
garth-wells 4163de3
Small update
garth-wells a8b2034
Merge branch 'main' into garth/bc-optional
garth-wells d65a2ac
Demo update
garth-wells 19795db
Binding fix
garth-wells 1bfeda5
Add no convert
garth-wells bfed4bd
Ruff fix
garth-wells 5d5cf01
Reduce code duplication
garth-wells 2a8532c
Merge branch 'main' into garth/bc-optional
garth-wells 88a00b4
Small fix
garth-wells 7d3bcfe
Tidy up
garth-wells bb2c9ac
Tidy
garth-wells 5a3c24e
Named argument update
garth-wells d53dc87
Test updates
garth-wells 4d2518d
Small fix
garth-wells baca347
More fixes
garth-wells c425e9e
Add BC set function
garth-wells 3cea94c
Simplify
garth-wells 5af4a95
Updates
garth-wells 41ee465
C++ updates
garth-wells 1c51c52
Remove commented code
garth-wells 0700d7d
Updates
garth-wells e3f2b90
Fix warning
garth-wells 5d2ff4a
Demo update
garth-wells dcb091e
Merge branch 'main' into garth/bc-optional
garth-wells 02d6dae
Improve docs
garth-wells 959bfde
Merge branch 'garth/bc-optional' of github.com:FEniCS/dolfinx into ga…
garth-wells f8d2e84
Small updates
garth-wells bc88ca0
Simplifications
garth-wells 8580933
Merge remote-tracking branch 'origin/main' into garth/bc-optional
garth-wells 6917e6e
Argument name fix in deprecated function
garth-wells 5d4d806
Add Python docs
garth-wells d94046a
Merge branch 'main' into garth/bc-optional
garth-wells 5b22044
Remove duplicated code
garth-wells 60702a6
Merge branch 'garth/bc-optional' of github.com:FEniCS/dolfinx into ga…
garth-wells 6afab22
Simplification
garth-wells c7fb71d
Merge branch 'main' into garth/bc-optional
garth-wells File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangential, but do we have a set style on this? Personally I prefer using floating point literals even if a cast from an integer literal is possible. We are also using
T(1)
below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our house (
0.0
) style pre-dates supporting different types. I preferto
because it's less syntax. I think
is possibly misleading since
T
is not necessarilydouble
.