Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created landing page #282

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2024

Description

This PR fixes #257

@ghost ghost requested review from codecShivam and A91y as code owners May 31, 2024 16:41
@ghost
Copy link
Author

ghost commented May 31, 2024

@codecShivam this is how it looks
image
image
image
image
image

Copy link
Member

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Background element seem to overlap with the nav.

image

Same here too.

@ghost
Copy link
Author

ghost commented Jun 2, 2024

@A91y overlapping fixed

image

@ghost
Copy link
Author

ghost commented Jun 7, 2024

@codecShivam check I've added responsiveness to the page

Copy link
Member

@codecShivam codecShivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1: Padding Adjustment

Needs some padding from the x direction

Needs some padding adjustment in the x-direction to enhance the visual spacing.


Issue 2: Overlapping Content

This looks overlapped, give some gap

The content looks overlapped. Please add some gap between the elements to prevent overlapping.


Issue 3: Background Image Visibility

The background image is not visible on the smaller screen

The background image is not visible on smaller screens. Ensure the background image is responsive and visible across different screen sizes.


Issue 4: Responsive Layout

Work on this part wrap it in a way that on decreasing screen one element should go below and aligned to the center also change the text size for different screens

Wrap the elements in a way that, on decreasing the screen size, one element should go below and be aligned to the center. Also, adjust the text size for different screen sizes to maintain readability and alignment.


Issue 5: Text Visibility

The text is not visible

The text is not visible. Improve the text alignment or background to enhance visibility.


General Suggestions for Improvement

  • Breakpoints: Focus on creating three breakpoints to handle different screen sizes. Adjust sizes, alignments, and spacing accordingly.
  • Text Size: Ensure text sizes are responsive and legible on all devices.
  • Alignment: Maintain proper alignment to ensure elements do not overlap and are visually appealing.

Additional Suggestion

To ensure the design is properly viewed on all screens and devices, use the extension available at https://mobileview.io/.

Excellent work, @piyusesh!

@ghost
Copy link
Author

ghost commented Jun 8, 2024

@codecShivam lmk if more improvements are needed

@Mr-Sunglasses
Copy link
Member

@codecShivam lmk if more improvements are needed

@codecShivam Review it ASAP

@codecShivam
Copy link
Member

@codecShivam lmk if more improvements are needed

@codecShivam Review it ASAP

Yeah, will review it by today.

@codecShivam
Copy link
Member

@codecShivam lmk if more improvements are needed

everything lgm!!
Just use the next/Image and remove this warning by providing width and height to it
image

@codecShivam
Copy link
Member

codecShivam commented Jun 12, 2024

lgm!!
but the warning is not resolved yet
take ref from here: https://nextjs.org/docs/pages/building-your-application/optimizing/images
cc: @piyusesh

@ghost
Copy link
Author

ghost commented Jun 12, 2024

@codecShivam done

@codecShivam
Copy link
Member

@codecShivam done

image

fix this in hero component as well

@codecShivam codecShivam merged commit 6a1d1f6 into FOSS-Community:web2.0-dev Jun 13, 2024
1 check passed
@codecShivam
Copy link
Member

Thanks! @piyusesh
cc: @A91y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants