Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re-)add RPKI VRF support #14220

Closed
urscale opened this issue Aug 17, 2023 · 7 comments
Closed

(Re-)add RPKI VRF support #14220

urscale opened this issue Aug 17, 2023 · 7 comments
Assignees

Comments

@urscale
Copy link

urscale commented Aug 17, 2023

After #5015 introduced the option of configuring RPKI in a VRF context (and FRR 7.5 release notes proudly mentioning rpki VRF support), those changes got reverted in #6740 due to rtlib lacking the required support (rtrlib/rtrlib#252).

With rtlib 0.8.0 now coming with the necessary prerequisites, is there any chance we could see RPKI VRF support brought back to life?

Unfortunately, attempting to revert-the-revert from #6740 leaves me with too many merge conflicts in order to provide a clean PR, so it would be very much appreciated if maybe @pguibert6WIND or someone else could have another look..?

@ton31337 ton31337 added the bgp label Aug 17, 2023
@ton31337 ton31337 self-assigned this Aug 17, 2023
@pguibert6WIND
Copy link
Member

pguibert6WIND commented Aug 18, 2023

Thanks @urscale ,
rpki per vrf support can be re-backported, but there is an extra-dependency:

https://github.com/rtrlib/rtrlib/releases/tag/v0.8.0 is needed.
so if this library is not available on current distributions, this will not be possible.

@ton31337
Copy link
Member

@pguibert6WIND do you want to re-add vrf support or no time for that? In terms of librtr, we have 0.8.0 in our deb/rpm repos, that's not an issue anymore.

@pguibert6WIND
Copy link
Member

yes, I will re-add it when some bandwidth is available.

Copy link

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

@frrbot
Copy link

frrbot bot commented Feb 29, 2024

This issue will be automatically closed in the specified period unless there is further activity.

@pguibert6WIND
Copy link
Member

task done

@frrbot frrbot bot removed the autoclose label Feb 29, 2024
@frrbot
Copy link

frrbot bot commented Feb 29, 2024

This issue will no longer be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants