isisd: create ext_reachability tlv when necessary #12253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
2c58a4a
to
6ac9cb8
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log found |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8203/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
|
ci:rerun dont know why, but redhat build failed |
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log found |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsRedhat 8 amd64 build: Failed (click for details)Redhat 8 amd64 build: No useful log found |
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8233/artifact/TOPO9U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8233/artifact/TOPO9U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found |
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
6ac9cb8
to
b9c99e6
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8242/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8242/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 |
pushpasis
approved these changes
Nov 8, 2022
odd22
reviewed
Nov 15, 2022
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
b9c99e6
to
dbdeff4
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-13866/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13866/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-13866/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13866/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found |
|
@pguibert6WIND could you fix CI warnings before merging? |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13866/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13866/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found |
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
dbdeff4
to
05390a4
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
ton31337
force-pushed
the
isis_update_ext_reach_tlv
branch
from
05390a4
to
605b7b2
Compare
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
605b7b2
to
b68823c
Compare
This commit addresses the case where the LSP entries
of a given device do not contain the local address in
the extended IS reachability TLV option. The below output
shows that the local address is not present in the option:
east-vm# show isis database detail east-vm.00-00
[..]
Extended Reachability: 0007.e901.1111.00 (Metric: 10)
Remote Interface IP Address(es): 10.125.0.1
Adjacency-SID: 30000, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Extended Reachability: 0007.e901.3333.00 (Metric: 10)
Remote Interface IP Address(es): 10.126.0.3
Adjacency-SID: 30001, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
[..]
The below output shows what is expected:
east-vm# show isis database detail east-vm.00-00
[..]
Extended Reachability: 0007.e901.1111.00 (Metric: 10)
Local Interface IP Address(es): 10.125.0.2
Remote Interface IP Address(es): 10.125.0.1
Adjacency-SID: 30000, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Extended Reachability: 0007.e901.3333.00 (Metric: 10)
Local Interface IP Address(es): 10.126.0.2
Remote Interface IP Address(es): 10.126.0.3
Adjacency-SID: 30001, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Not having the local address in the LSP results in creating
an invalid traffic engineering database. This inconsistency
leads to crashes when unconfiguring the isis instance.
The analysis shows the following:
When the configuration is loaded at startup, the interfaces
are not always available, and the presence of the interface
may be detected after the MPLS-TE activation is done. When
the new interface event is triggered, the area is attached to
the new interface circuit, but as the TLV extension has not been
initialised on the circuit, it is not possible to populate
the local address of the interface.
The attached commit consists in creating the TLV extension structure
if MPLS-TE is enabled. Then the local address is populated.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
isis_update_ext_reach_tlv
branch
from
b68823c
to
f44f0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the case where the LSP entries of a given device do not contain the local address in the ISIS ext TLV option. The below output shows that the local address is not present in the option:
east-vm# show isis database detail east-vm.00-00
[..]
Extended Reachability: 0007.e901.1111.00 (Metric: 10)
Remote Interface IP Address(es): 10.125.0.1
Adjacency-SID: 30000, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Extended Reachability: 0007.e901.3333.00 (Metric: 10)
Remote Interface IP Address(es): 10.126.0.3
Adjacency-SID: 30001, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
[..]
The below output shows what is expected:
east-vm# show isis database detail east-vm.00-00
[..]
Extended Reachability: 0007.e901.1111.00 (Metric: 10)
Local Interface IP Address(es): 10.125.0.2
Remote Interface IP Address(es): 10.125.0.1
Adjacency-SID: 30000, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Extended Reachability: 0007.e901.3333.00 (Metric: 10)
Local Interface IP Address(es): 10.126.0.2
Remote Interface IP Address(es): 10.126.0.3
Adjacency-SID: 30001, Weight: 0, Flags: F:0 B:0, V:1, L:1, S:0, P:0
Not having the local address in the LSP results in creating an invalid traffic engineering database. This inconsistency leads to crashes when unconfiguring the isis instance.
The analysis shows the following:
When the configuration is loaded at startup, the interfaces are not always available, and the presence of the interface may be detected after the MPLS-TE activation is done. When the new interface event is triggered, the area is attahed to the new interface circuit, but as the TLV extension has not been initialised on the circuit, it is not possible to populate the local address of the interface.
The proposed commit consists in creating the TLV extension structure if MPLS-TE is enabled. Then the local address is populated.
Signed-off-by: Philippe Guibert philippe.guibert@6wind.com