ospfd: Configurable interface-level 'capability opaque' support #13691

aceelindem · 2023-06-05T21:40:11Z

Add support for "[no] ip ospf capbility opaque" at the interface level with the default being capability opaque enabled. The command "no ip ospf capability opaque" will disable opaque LSA database exchange and flooding on the interface. A change in configuration will result in the interface being flapped to update our options for neighbors but no attempt will be made to purge existing LSAs as in dense topologies, these may received by neighbors through different interfaces.

Topotests are added to test both the configuration and the LSA opaque flooding suppression.

NetDEF-CI · 2023-06-05T22:13:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
ospfd/ospf_flood.c: In function ospf_flood_through_interface:
./lib/zlog.h:109:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type const char * [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
ospfd/ospf_flood.c:574:4: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10532: ospfd/ospf_flood.o] Error 1
/home/ci/cibuild.12017/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.12017/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Ubuntu 18.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
CentOS 7 amd64 build
Redhat 8 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 20.04 amd64 build
Debian 9 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
FreeBSD 11 amd64 build
Ubuntu 22.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
ospfd/ospf_flood.c: In function ospf_flood_through_interface:
./lib/zlog.h:109:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type const char * [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
ospfd/ospf_flood.c:574:4: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10532: ospfd/ospf_flood.o] Error 1
/home/ci/cibuild.12017/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.12017/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12017/artifact/DEB11AMD64/config.status/config.status

Report for ospf_vty.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #9699: FILE: /tmp/f1-3475891/ospf_vty.c:9699:
< WARNING: Missing a blank line after declarations
< #9760: FILE: /tmp/f1-3475891/ospf_vty.c:9760:

aceelindem · 2023-06-05T23:44:48Z

ci:rerun

NetDEF-CI · 2023-06-06T02:26:31Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Addresssanitizer topotests part 9: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `test_ospf_gr_topo1.py`, test `teardown_module`, router `rt1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x55874b4f9f5d bp 0x7ffcdb6a3050 sp 0x7ffcdb6a3020 T0)
    ==18430==The signal is caused by a READ memory access.
    ==18430==Hint: address points to the zero page.
        #0 0x55874b4f9f5c in ospf_gr_prepare ospfd/ospf_gr.c:769
        #1 0x55874b4f9f5c in graceful_restart_prepare_magic ospfd/ospf_gr.c:810
        #2 0x55874b4f9f5c in graceful_restart_prepare ospfd/ospf_gr_clippy.c:37
        #3 0x55874b62d3d0 in cmd_execute_command_real lib/command.c:994
        #4 0x55874b62d89d in cmd_execute_command lib/command.c:1053
        #5 0x55874b62dd14 in cmd_execute lib/command.c:1221
        #6 0x55874b74ec9a in vty_command lib/vty.c:559
        #7 0x55874b74f134 in vty_execute lib/vty.c:1322
        #8 0x55874b7577bf in vtysh_read lib/vty.c:2307
        #9 0x55874b742ba8 in event_call lib/event.c:1995
        #10 0x55874b688919 in frr_run lib/libfrr.c:1213
        #11 0x55874b4ed144 in main ospfd/ospf_main.c:220
        #12 0x7eff60c8fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #13 0x55874b4ecbf9 in _start (/usr/lib/frr/ospfd+0x2e1bf9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV ospfd/ospf_gr.c:769 in ospf_gr_prepare

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12020/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 2
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Addresssanitizer topotests part 9: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `test_ospf_gr_topo1.py`, test `teardown_module`, router `rt1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x55874b4f9f5d bp 0x7ffcdb6a3050 sp 0x7ffcdb6a3020 T0)
    ==18430==The signal is caused by a READ memory access.
    ==18430==Hint: address points to the zero page.
        #0 0x55874b4f9f5c in ospf_gr_prepare ospfd/ospf_gr.c:769
        #1 0x55874b4f9f5c in graceful_restart_prepare_magic ospfd/ospf_gr.c:810
        #2 0x55874b4f9f5c in graceful_restart_prepare ospfd/ospf_gr_clippy.c:37
        #3 0x55874b62d3d0 in cmd_execute_command_real lib/command.c:994
        #4 0x55874b62d89d in cmd_execute_command lib/command.c:1053
        #5 0x55874b62dd14 in cmd_execute lib/command.c:1221
        #6 0x55874b74ec9a in vty_command lib/vty.c:559
        #7 0x55874b74f134 in vty_execute lib/vty.c:1322
        #8 0x55874b7577bf in vtysh_read lib/vty.c:2307
        #9 0x55874b742ba8 in event_call lib/event.c:1995
        #10 0x55874b688919 in frr_run lib/libfrr.c:1213
        #11 0x55874b4ed144 in main ospfd/ospf_main.c:220
        #12 0x7eff60c8fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #13 0x55874b4ecbf9 in _start (/usr/lib/frr/ospfd+0x2e1bf9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV ospfd/ospf_gr.c:769 in ospf_gr_prepare

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12020/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO9U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Report for ospf_vty.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #9699: FILE: /tmp/f1-4165695/ospf_vty.c:9699:
< WARNING: Missing a blank line after declarations
< #9760: FILE: /tmp/f1-4165695/ospf_vty.c:9760:

CLANG Static Analyzer Summary

Github Pull Request 13691, comparing to Git base SHA fecc953
Base image data for Git fecc953 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-12020/artifact/shared/static_analysis/index.html

NetDEF-CI · 2023-06-06T02:34:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12019/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Addresssanitizer topotests part 9: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `test_ospf_gr_topo1.py`, test `teardown_module`, router `rt1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x557942392f5d bp 0x7ffcc1790910 sp 0x7ffcc17908e0 T0)
    ==26740==The signal is caused by a READ memory access.
    ==26740==Hint: address points to the zero page.
        #0 0x557942392f5c in ospf_gr_prepare ospfd/ospf_gr.c:769
        #1 0x557942392f5c in graceful_restart_prepare_magic ospfd/ospf_gr.c:810
        #2 0x557942392f5c in graceful_restart_prepare ospfd/ospf_gr_clippy.c:37
        #3 0x5579424c63d0 in cmd_execute_command_real lib/command.c:994
        #4 0x5579424c689d in cmd_execute_command lib/command.c:1053
        #5 0x5579424c6d14 in cmd_execute lib/command.c:1221
        #6 0x5579425e7c9a in vty_command lib/vty.c:559
        #7 0x5579425e8134 in vty_execute lib/vty.c:1322
        #8 0x5579425f07bf in vtysh_read lib/vty.c:2307
        #9 0x5579425dbba8 in event_call lib/event.c:1995
        #10 0x557942521919 in frr_run lib/libfrr.c:1213
        #11 0x557942386144 in main ospfd/ospf_main.c:220
        #12 0x7fba99f8fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #13 0x557942385bf9 in _start (/usr/lib/frr/ospfd+0x2e1bf9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV ospfd/ospf_gr.c:769 in ospf_gr_prepare

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12019/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 7

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12019/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Addresssanitizer topotests part 9: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `test_ospf_gr_topo1.py`, test `teardown_module`, router `rt1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x557942392f5d bp 0x7ffcc1790910 sp 0x7ffcc17908e0 T0)
    ==26740==The signal is caused by a READ memory access.
    ==26740==Hint: address points to the zero page.
        #0 0x557942392f5c in ospf_gr_prepare ospfd/ospf_gr.c:769
        #1 0x557942392f5c in graceful_restart_prepare_magic ospfd/ospf_gr.c:810
        #2 0x557942392f5c in graceful_restart_prepare ospfd/ospf_gr_clippy.c:37
        #3 0x5579424c63d0 in cmd_execute_command_real lib/command.c:994
        #4 0x5579424c689d in cmd_execute_command lib/command.c:1053
        #5 0x5579424c6d14 in cmd_execute lib/command.c:1221
        #6 0x5579425e7c9a in vty_command lib/vty.c:559
        #7 0x5579425e8134 in vty_execute lib/vty.c:1322
        #8 0x5579425f07bf in vtysh_read lib/vty.c:2307
        #9 0x5579425dbba8 in event_call lib/event.c:1995
        #10 0x557942521919 in frr_run lib/libfrr.c:1213
        #11 0x557942386144 in main ospfd/ospf_main.c:220
        #12 0x7fba99f8fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #13 0x557942385bf9 in _start (/usr/lib/frr/ospfd+0x2e1bf9)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV ospfd/ospf_gr.c:769 in ospf_gr_prepare

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12019/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO9U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Report for ospf_vty.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #9699: FILE: /tmp/f1-4121908/ospf_vty.c:9699:
< WARNING: Missing a blank line after declarations
< #9760: FILE: /tmp/f1-4121908/ospf_vty.c:9760:

CLANG Static Analyzer Summary

Github Pull Request 13691, comparing to Git base SHA fecc953
Base image data for Git fecc953 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-12019/artifact/shared/static_analysis/index.html

ospfd/ospf_vty.c

rgirada · 2023-06-06T07:33:34Z

Please update ospf documentation for this change.

NetDEF-CI · 2023-06-06T20:25:08Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12044/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0000458fa at pc 0x56326d9f5952 bp 0x7ffc80431490 sp 0x7ffc80431480
    READ of size 1 at 0x60c0000458fa thread T0
        #0 0x56326d9f5951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x56326d9f5951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x56326da8ddac in cmd_execute_command_real lib/command.c:994
        #3 0x56326da8e279 in cmd_execute_command lib/command.c:1053
        #4 0x56326da8e6f0 in cmd_execute lib/command.c:1221
        #5 0x56326dbaf67a in vty_command lib/vty.c:559
        #6 0x56326dbafb14 in vty_execute lib/vty.c:1322
        #7 0x56326dbb8229 in vtysh_read lib/vty.c:2307
        #8 0x56326dba3588 in event_call lib/event.c:1995
        #9 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #10 0x56326d94d604 in main ospfd/ospf_main.c:220
        #11 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x56326d94d0b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c0000458fa is located 122 bytes inside of 128-byte region [0x60c000045880,0x60c000045900)
    freed by thread T0 here:
        #0 0x7fd3db53d7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x56326db06a5d in qfree lib/memory.c:130
        #2 0x56326d95cbb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x56326d95ff47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x56326d9f5773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x56326d9f5773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x56326da8ddac in cmd_execute_command_real lib/command.c:994
        #7 0x56326da8e279 in cmd_execute_command lib/command.c:1053
        #8 0x56326da8e6f0 in cmd_execute lib/command.c:1221
        #9 0x56326dbaf67a in vty_command lib/vty.c:559
        #10 0x56326dbafb14 in vty_execute lib/vty.c:1322
        #11 0x56326dbb8229 in vtysh_read lib/vty.c:2307
        #12 0x56326dba3588 in event_call lib/event.c:1995
        #13 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #14 0x56326d94d604 in main ospfd/ospf_main.c:220
        #15 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fd3db53dd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x56326db060c9 in qcalloc lib/memory.c:105
        #2 0x56326d95c538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x56326d96060d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x56326d9709f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x56326d97f4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x56326d98b89b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x56326d98b89b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x56326dba3588 in event_call lib/event.c:1995
        #9 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #10 0x56326d94d604 in main ospfd/ospf_main.c:220
        #11 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b00: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000b10: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000b20: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b30: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000b40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000b50: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b60: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12044/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/ASAN9/TopotestDetails/

Successful on other platforms/tests

Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Static analyzer (clang)
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12044/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0000458fa at pc 0x56326d9f5952 bp 0x7ffc80431490 sp 0x7ffc80431480
    READ of size 1 at 0x60c0000458fa thread T0
        #0 0x56326d9f5951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x56326d9f5951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x56326da8ddac in cmd_execute_command_real lib/command.c:994
        #3 0x56326da8e279 in cmd_execute_command lib/command.c:1053
        #4 0x56326da8e6f0 in cmd_execute lib/command.c:1221
        #5 0x56326dbaf67a in vty_command lib/vty.c:559
        #6 0x56326dbafb14 in vty_execute lib/vty.c:1322
        #7 0x56326dbb8229 in vtysh_read lib/vty.c:2307
        #8 0x56326dba3588 in event_call lib/event.c:1995
        #9 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #10 0x56326d94d604 in main ospfd/ospf_main.c:220
        #11 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x56326d94d0b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c0000458fa is located 122 bytes inside of 128-byte region [0x60c000045880,0x60c000045900)
    freed by thread T0 here:
        #0 0x7fd3db53d7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x56326db06a5d in qfree lib/memory.c:130
        #2 0x56326d95cbb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x56326d95ff47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x56326d9f5773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x56326d9f5773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x56326da8ddac in cmd_execute_command_real lib/command.c:994
        #7 0x56326da8e279 in cmd_execute_command lib/command.c:1053
        #8 0x56326da8e6f0 in cmd_execute lib/command.c:1221
        #9 0x56326dbaf67a in vty_command lib/vty.c:559
        #10 0x56326dbafb14 in vty_execute lib/vty.c:1322
        #11 0x56326dbb8229 in vtysh_read lib/vty.c:2307
        #12 0x56326dba3588 in event_call lib/event.c:1995
        #13 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #14 0x56326d94d604 in main ospfd/ospf_main.c:220
        #15 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fd3db53dd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x56326db060c9 in qcalloc lib/memory.c:105
        #2 0x56326d95c538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x56326d96060d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x56326d9709f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x56326d97f4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x56326d98b89b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x56326d98b89b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x56326dba3588 in event_call lib/event.c:1995
        #9 0x56326dae92f5 in frr_run lib/libfrr.c:1213
        #10 0x56326d94d604 in main ospfd/ospf_main.c:220
        #11 0x7fd3d9d99c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b00: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000b10: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000b20: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b30: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000b40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000b50: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b60: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12044/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12044/artifact/ASAN9/TopotestDetails/

Report for ospf_vty.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3779: FILE: /tmp/f1-1015771/ospf_vty.c:3779:
< WARNING: please, no spaces at the start of a line
< #3779: FILE: /tmp/f1-1015771/ospf_vty.c:3779:
< ERROR: code indent should use tabs where possible
< #3780: FILE: /tmp/f1-1015771/ospf_vty.c:3780:
< WARNING: please, no spaces at the start of a line
< #3780: FILE: /tmp/f1-1015771/ospf_vty.c:3780:
< ERROR: code indent should use tabs where possible
< #3781: FILE: /tmp/f1-1015771/ospf_vty.c:3781:
< WARNING: please, no spaces at the start of a line
< #3781: FILE: /tmp/f1-1015771/ospf_vty.c:3781:
< ERROR: code indent should use tabs where possible
< #3782: FILE: /tmp/f1-1015771/ospf_vty.c:3782:
< WARNING: please, no spaces at the start of a line
< #3782: FILE: /tmp/f1-1015771/ospf_vty.c:3782:
< WARNING: Missing a blank line after declarations
< #9698: FILE: /tmp/f1-1015771/ospf_vty.c:9698:
< WARNING: Missing a blank line after declarations
< #9759: FILE: /tmp/f1-1015771/ospf_vty.c:9759:

NetDEF-CI · 2023-06-06T23:52:02Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12049/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12049/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0000458fa at pc 0x555bf7287952 bp 0x7ffc1cf1b9e0 sp 0x7ffc1cf1b9d0
    READ of size 1 at 0x60c0000458fa thread T0
        #0 0x555bf7287951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x555bf7287951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x555bf731fdac in cmd_execute_command_real lib/command.c:994
        #3 0x555bf7320279 in cmd_execute_command lib/command.c:1053
        #4 0x555bf73206f0 in cmd_execute lib/command.c:1221
        #5 0x555bf744167a in vty_command lib/vty.c:559
        #6 0x555bf7441b14 in vty_execute lib/vty.c:1322
        #7 0x555bf744a229 in vtysh_read lib/vty.c:2307
        #8 0x555bf7435588 in event_call lib/event.c:1995
        #9 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #10 0x555bf71df604 in main ospfd/ospf_main.c:220
        #11 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x555bf71df0b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c0000458fa is located 122 bytes inside of 128-byte region [0x60c000045880,0x60c000045900)
    freed by thread T0 here:
        #0 0x7fababc887a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x555bf7398a5d in qfree lib/memory.c:130
        #2 0x555bf71eebb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x555bf71f1f47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x555bf7287773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x555bf7287773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x555bf731fdac in cmd_execute_command_real lib/command.c:994
        #7 0x555bf7320279 in cmd_execute_command lib/command.c:1053
        #8 0x555bf73206f0 in cmd_execute lib/command.c:1221
        #9 0x555bf744167a in vty_command lib/vty.c:559
        #10 0x555bf7441b14 in vty_execute lib/vty.c:1322
        #11 0x555bf744a229 in vtysh_read lib/vty.c:2307
        #12 0x555bf7435588 in event_call lib/event.c:1995
        #13 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #14 0x555bf71df604 in main ospfd/ospf_main.c:220
        #15 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fababc88d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x555bf73980c9 in qcalloc lib/memory.c:105
        #2 0x555bf71ee538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x555bf71f260d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x555bf72029f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x555bf72114b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x555bf721d89b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x555bf721d89b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x555bf7435588 in event_call lib/event.c:1995
        #9 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #10 0x555bf71df604 in main ospfd/ospf_main.c:220
        #11 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b00: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000b10: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000b20: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b30: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000b40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000b50: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b60: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12049/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12049/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12049/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0000458fa at pc 0x555bf7287952 bp 0x7ffc1cf1b9e0 sp 0x7ffc1cf1b9d0
    READ of size 1 at 0x60c0000458fa thread T0
        #0 0x555bf7287951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x555bf7287951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x555bf731fdac in cmd_execute_command_real lib/command.c:994
        #3 0x555bf7320279 in cmd_execute_command lib/command.c:1053
        #4 0x555bf73206f0 in cmd_execute lib/command.c:1221
        #5 0x555bf744167a in vty_command lib/vty.c:559
        #6 0x555bf7441b14 in vty_execute lib/vty.c:1322
        #7 0x555bf744a229 in vtysh_read lib/vty.c:2307
        #8 0x555bf7435588 in event_call lib/event.c:1995
        #9 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #10 0x555bf71df604 in main ospfd/ospf_main.c:220
        #11 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x555bf71df0b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c0000458fa is located 122 bytes inside of 128-byte region [0x60c000045880,0x60c000045900)
    freed by thread T0 here:
        #0 0x7fababc887a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x555bf7398a5d in qfree lib/memory.c:130
        #2 0x555bf71eebb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x555bf71f1f47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x555bf7287773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x555bf7287773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x555bf731fdac in cmd_execute_command_real lib/command.c:994
        #7 0x555bf7320279 in cmd_execute_command lib/command.c:1053
        #8 0x555bf73206f0 in cmd_execute lib/command.c:1221
        #9 0x555bf744167a in vty_command lib/vty.c:559
        #10 0x555bf7441b14 in vty_execute lib/vty.c:1322
        #11 0x555bf744a229 in vtysh_read lib/vty.c:2307
        #12 0x555bf7435588 in event_call lib/event.c:1995
        #13 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #14 0x555bf71df604 in main ospfd/ospf_main.c:220
        #15 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fababc88d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x555bf73980c9 in qcalloc lib/memory.c:105
        #2 0x555bf71ee538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x555bf71f260d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x555bf72029f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x555bf72114b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x555bf721d89b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x555bf721d89b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x555bf7435588 in event_call lib/event.c:1995
        #9 0x555bf737b2f5 in frr_run lib/libfrr.c:1213
        #10 0x555bf71df604 in main ospfd/ospf_main.c:220
        #11 0x7fabaa4e4c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b00: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000b10: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000b20: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b30: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000b40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000b50: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000b60: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12049/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12049/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for ospf_vty.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3779: FILE: /tmp/f1-2672534/ospf_vty.c:3779:
< WARNING: please, no spaces at the start of a line
< #3779: FILE: /tmp/f1-2672534/ospf_vty.c:3779:
< ERROR: code indent should use tabs where possible
< #3780: FILE: /tmp/f1-2672534/ospf_vty.c:3780:
< WARNING: please, no spaces at the start of a line
< #3780: FILE: /tmp/f1-2672534/ospf_vty.c:3780:
< ERROR: code indent should use tabs where possible
< #3781: FILE: /tmp/f1-2672534/ospf_vty.c:3781:
< WARNING: please, no spaces at the start of a line
< #3781: FILE: /tmp/f1-2672534/ospf_vty.c:3781:
< ERROR: code indent should use tabs where possible
< #3782: FILE: /tmp/f1-2672534/ospf_vty.c:3782:
< WARNING: please, no spaces at the start of a line
< #3782: FILE: /tmp/f1-2672534/ospf_vty.c:3782:
< WARNING: Missing a blank line after declarations
< #9698: FILE: /tmp/f1-2672534/ospf_vty.c:9698:
< WARNING: Missing a blank line after declarations
< #9759: FILE: /tmp/f1-2672534/ospf_vty.c:9759:

aceelindem · 2023-06-07T15:25:26Z

Please update ospf documentation for this change.

Updated User Documentation - see ospfd.rst file.

NetDEF-CI · 2023-06-07T17:00:51Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12073/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x55f6aa871952 bp 0x7fff5ac02420 sp 0x7fff5ac02410
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x55f6aa871951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x55f6aa871951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x55f6aa909dac in cmd_execute_command_real lib/command.c:994
        #3 0x55f6aa90a279 in cmd_execute_command lib/command.c:1053
        #4 0x55f6aa90a6f0 in cmd_execute lib/command.c:1221
        #5 0x55f6aaa2b67a in vty_command lib/vty.c:559
        #6 0x55f6aaa2bb14 in vty_execute lib/vty.c:1322
        #7 0x55f6aaa34229 in vtysh_read lib/vty.c:2311
        #8 0x55f6aaa1f588 in event_call lib/event.c:1995
        #9 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #10 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #11 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x55f6aa7c90b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f5c327bd7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x55f6aa982a5d in qfree lib/memory.c:130
        #2 0x55f6aa7d8bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x55f6aa7dbf47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x55f6aa871773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x55f6aa871773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x55f6aa909dac in cmd_execute_command_real lib/command.c:994
        #7 0x55f6aa90a279 in cmd_execute_command lib/command.c:1053
        #8 0x55f6aa90a6f0 in cmd_execute lib/command.c:1221
        #9 0x55f6aaa2b67a in vty_command lib/vty.c:559
        #10 0x55f6aaa2bb14 in vty_execute lib/vty.c:1322
        #11 0x55f6aaa34229 in vtysh_read lib/vty.c:2311
        #12 0x55f6aaa1f588 in event_call lib/event.c:1995
        #13 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #14 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #15 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f5c327bdd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x55f6aa9820c9 in qcalloc lib/memory.c:105
        #2 0x55f6aa7d8538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x55f6aa7dc60d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x55f6aa7ec9f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x55f6aa7fb4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x55f6aa80789b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x55f6aa80789b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x55f6aaa1f588 in event_call lib/event.c:1995
        #9 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #10 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #11 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12073/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12073/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18AMD64/TopotestDetails/

Successful on other platforms/tests

CentOS 7 rpm pkg check
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Debian 9 deb pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12073/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x55f6aa871952 bp 0x7fff5ac02420 sp 0x7fff5ac02410
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x55f6aa871951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x55f6aa871951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x55f6aa909dac in cmd_execute_command_real lib/command.c:994
        #3 0x55f6aa90a279 in cmd_execute_command lib/command.c:1053
        #4 0x55f6aa90a6f0 in cmd_execute lib/command.c:1221
        #5 0x55f6aaa2b67a in vty_command lib/vty.c:559
        #6 0x55f6aaa2bb14 in vty_execute lib/vty.c:1322
        #7 0x55f6aaa34229 in vtysh_read lib/vty.c:2311
        #8 0x55f6aaa1f588 in event_call lib/event.c:1995
        #9 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #10 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #11 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x55f6aa7c90b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f5c327bd7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x55f6aa982a5d in qfree lib/memory.c:130
        #2 0x55f6aa7d8bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x55f6aa7dbf47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x55f6aa871773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x55f6aa871773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x55f6aa909dac in cmd_execute_command_real lib/command.c:994
        #7 0x55f6aa90a279 in cmd_execute_command lib/command.c:1053
        #8 0x55f6aa90a6f0 in cmd_execute lib/command.c:1221
        #9 0x55f6aaa2b67a in vty_command lib/vty.c:559
        #10 0x55f6aaa2bb14 in vty_execute lib/vty.c:1322
        #11 0x55f6aaa34229 in vtysh_read lib/vty.c:2311
        #12 0x55f6aaa1f588 in event_call lib/event.c:1995
        #13 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #14 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #15 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f5c327bdd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x55f6aa9820c9 in qcalloc lib/memory.c:105
        #2 0x55f6aa7d8538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x55f6aa7dc60d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x55f6aa7ec9f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x55f6aa7fb4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x55f6aa80789b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x55f6aa80789b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x55f6aaa1f588 in event_call lib/event.c:1995
        #9 0x55f6aa9652f5 in frr_run lib/libfrr.c:1213
        #10 0x55f6aa7c9604 in main ospfd/ospf_main.c:220
        #11 0x7f5c31019c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12073/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12073/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12073/artifact/TOPO9U18AMD64/TopotestDetails/

Report for ospf_vty.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3779: FILE: /tmp/f1-3778907/ospf_vty.c:3779:
< WARNING: please, no spaces at the start of a line
< #3779: FILE: /tmp/f1-3778907/ospf_vty.c:3779:
< ERROR: code indent should use tabs where possible
< #3780: FILE: /tmp/f1-3778907/ospf_vty.c:3780:
< WARNING: please, no spaces at the start of a line
< #3780: FILE: /tmp/f1-3778907/ospf_vty.c:3780:
< ERROR: code indent should use tabs where possible
< #3781: FILE: /tmp/f1-3778907/ospf_vty.c:3781:
< WARNING: please, no spaces at the start of a line
< #3781: FILE: /tmp/f1-3778907/ospf_vty.c:3781:
< ERROR: code indent should use tabs where possible
< #3782: FILE: /tmp/f1-3778907/ospf_vty.c:3782:
< WARNING: please, no spaces at the start of a line
< #3782: FILE: /tmp/f1-3778907/ospf_vty.c:3782:
< WARNING: Missing a blank line after declarations
< #9698: FILE: /tmp/f1-3778907/ospf_vty.c:9698:
< WARNING: Missing a blank line after declarations
< #9759: FILE: /tmp/f1-3778907/ospf_vty.c:9759:

NetDEF-CI · 2023-06-07T21:09:14Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12089/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x55ea48610952 bp 0x7ffe83cf8190 sp 0x7ffe83cf8180
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x55ea48610951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x55ea48610951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x55ea486a8dac in cmd_execute_command_real lib/command.c:994
        #3 0x55ea486a9279 in cmd_execute_command lib/command.c:1053
        #4 0x55ea486a96f0 in cmd_execute lib/command.c:1221
        #5 0x55ea487ca67a in vty_command lib/vty.c:559
        #6 0x55ea487cab14 in vty_execute lib/vty.c:1322
        #7 0x55ea487d3229 in vtysh_read lib/vty.c:2311
        #8 0x55ea487be588 in event_call lib/event.c:1995
        #9 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #10 0x55ea48568604 in main ospfd/ospf_main.c:220
        #11 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x55ea485680b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7fa971e737a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x55ea48721a5d in qfree lib/memory.c:130
        #2 0x55ea48577bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x55ea4857af47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x55ea48610773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x55ea48610773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x55ea486a8dac in cmd_execute_command_real lib/command.c:994
        #7 0x55ea486a9279 in cmd_execute_command lib/command.c:1053
        #8 0x55ea486a96f0 in cmd_execute lib/command.c:1221
        #9 0x55ea487ca67a in vty_command lib/vty.c:559
        #10 0x55ea487cab14 in vty_execute lib/vty.c:1322
        #11 0x55ea487d3229 in vtysh_read lib/vty.c:2311
        #12 0x55ea487be588 in event_call lib/event.c:1995
        #13 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #14 0x55ea48568604 in main ospfd/ospf_main.c:220
        #15 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fa971e73d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x55ea487210c9 in qcalloc lib/memory.c:105
        #2 0x55ea48577538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x55ea4857b60d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x55ea4858b9f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x55ea4859a4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x55ea485a689b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x55ea485a689b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x55ea487be588 in event_call lib/event.c:1995
        #9 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #10 0x55ea48568604 in main ospfd/ospf_main.c:220
        #11 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12089/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12089/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 7
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 6
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12089/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x55ea48610952 bp 0x7ffe83cf8190 sp 0x7ffe83cf8180
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x55ea48610951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x55ea48610951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x55ea486a8dac in cmd_execute_command_real lib/command.c:994
        #3 0x55ea486a9279 in cmd_execute_command lib/command.c:1053
        #4 0x55ea486a96f0 in cmd_execute lib/command.c:1221
        #5 0x55ea487ca67a in vty_command lib/vty.c:559
        #6 0x55ea487cab14 in vty_execute lib/vty.c:1322
        #7 0x55ea487d3229 in vtysh_read lib/vty.c:2311
        #8 0x55ea487be588 in event_call lib/event.c:1995
        #9 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #10 0x55ea48568604 in main ospfd/ospf_main.c:220
        #11 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x55ea485680b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7fa971e737a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x55ea48721a5d in qfree lib/memory.c:130
        #2 0x55ea48577bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x55ea4857af47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x55ea48610773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x55ea48610773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x55ea486a8dac in cmd_execute_command_real lib/command.c:994
        #7 0x55ea486a9279 in cmd_execute_command lib/command.c:1053
        #8 0x55ea486a96f0 in cmd_execute lib/command.c:1221
        #9 0x55ea487ca67a in vty_command lib/vty.c:559
        #10 0x55ea487cab14 in vty_execute lib/vty.c:1322
        #11 0x55ea487d3229 in vtysh_read lib/vty.c:2311
        #12 0x55ea487be588 in event_call lib/event.c:1995
        #13 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #14 0x55ea48568604 in main ospfd/ospf_main.c:220
        #15 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fa971e73d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x55ea487210c9 in qcalloc lib/memory.c:105
        #2 0x55ea48577538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x55ea4857b60d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x55ea4858b9f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x55ea4859a4b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x55ea485a689b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x55ea485a689b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x55ea487be588 in event_call lib/event.c:1995
        #9 0x55ea487042f5 in frr_run lib/libfrr.c:1213
        #10 0x55ea48568604 in main ospfd/ospf_main.c:220
        #11 0x7fa9706cfc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12089/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12089/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12089/artifact/TOPO9U18AMD64/TopotestDetails/

Report for ospf_vty.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3779: FILE: /tmp/f1-2414296/ospf_vty.c:3779:
< WARNING: please, no spaces at the start of a line
< #3779: FILE: /tmp/f1-2414296/ospf_vty.c:3779:
< ERROR: code indent should use tabs where possible
< #3780: FILE: /tmp/f1-2414296/ospf_vty.c:3780:
< WARNING: please, no spaces at the start of a line
< #3780: FILE: /tmp/f1-2414296/ospf_vty.c:3780:
< ERROR: code indent should use tabs where possible
< #3781: FILE: /tmp/f1-2414296/ospf_vty.c:3781:
< WARNING: please, no spaces at the start of a line
< #3781: FILE: /tmp/f1-2414296/ospf_vty.c:3781:
< ERROR: code indent should use tabs where possible
< #3782: FILE: /tmp/f1-2414296/ospf_vty.c:3782:
< WARNING: please, no spaces at the start of a line
< #3782: FILE: /tmp/f1-2414296/ospf_vty.c:3782:
< WARNING: Missing a blank line after declarations
< #9698: FILE: /tmp/f1-2414296/ospf_vty.c:9698:
< WARNING: Missing a blank line after declarations
< #9759: FILE: /tmp/f1-2414296/ospf_vty.c:9759:

github-actions · 2023-06-08T19:11:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

NetDEF-CI · 2023-06-08T19:27:04Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO7U18I386/TopotestDetails/

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12140/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO3DEB10AMD64/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x56396e0ae952 bp 0x7ffed8c42880 sp 0x7ffed8c42870
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x56396e0ae951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x56396e0ae951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x56396e146def in cmd_execute_command_real lib/command.c:994
        #3 0x56396e1472bc in cmd_execute_command lib/command.c:1053
        #4 0x56396e147733 in cmd_execute lib/command.c:1221
        #5 0x56396e2686ba in vty_command lib/vty.c:559
        #6 0x56396e268b54 in vty_execute lib/vty.c:1322
        #7 0x56396e271269 in vtysh_read lib/vty.c:2311
        #8 0x56396e25c5c8 in event_call lib/event.c:1995
        #9 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #10 0x56396e006604 in main ospfd/ospf_main.c:220
        #11 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x56396e0060b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f03a5a8a7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x56396e1bfaa0 in qfree lib/memory.c:130
        #2 0x56396e015bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x56396e018f47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x56396e0ae773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x56396e0ae773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x56396e146def in cmd_execute_command_real lib/command.c:994
        #7 0x56396e1472bc in cmd_execute_command lib/command.c:1053
        #8 0x56396e147733 in cmd_execute lib/command.c:1221
        #9 0x56396e2686ba in vty_command lib/vty.c:559
        #10 0x56396e268b54 in vty_execute lib/vty.c:1322
        #11 0x56396e271269 in vtysh_read lib/vty.c:2311
        #12 0x56396e25c5c8 in event_call lib/event.c:1995
        #13 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #14 0x56396e006604 in main ospfd/ospf_main.c:220
        #15 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f03a5a8ad28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x56396e1bf10c in qcalloc lib/memory.c:105
        #2 0x56396e015538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x56396e01960d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x56396e0299f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x56396e0384b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x56396e04489b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x56396e04489b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x56396e25c5c8 in event_call lib/event.c:1995
        #9 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #10 0x56396e006604 in main ospfd/ospf_main.c:220
        #11 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12140/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO8U18ARM64/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 4
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 6
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO7U18I386/TopotestDetails/

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12140/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO3DEB10AMD64/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x56396e0ae952 bp 0x7ffed8c42880 sp 0x7ffed8c42870
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x56396e0ae951 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9727
        #1 0x56396e0ae951 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #2 0x56396e146def in cmd_execute_command_real lib/command.c:994
        #3 0x56396e1472bc in cmd_execute_command lib/command.c:1053
        #4 0x56396e147733 in cmd_execute lib/command.c:1221
        #5 0x56396e2686ba in vty_command lib/vty.c:559
        #6 0x56396e268b54 in vty_execute lib/vty.c:1322
        #7 0x56396e271269 in vtysh_read lib/vty.c:2311
        #8 0x56396e25c5c8 in event_call lib/event.c:1995
        #9 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #10 0x56396e006604 in main ospfd/ospf_main.c:220
        #11 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x56396e0060b9 in _start (/usr/lib/frr/ospfd+0x2e20b9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f03a5a8a7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x56396e1bfaa0 in qfree lib/memory.c:130
        #2 0x56396e015bb2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x56396e018f47 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x56396e0ae773 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9718
        #5 0x56396e0ae773 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1125
        #6 0x56396e146def in cmd_execute_command_real lib/command.c:994
        #7 0x56396e1472bc in cmd_execute_command lib/command.c:1053
        #8 0x56396e147733 in cmd_execute lib/command.c:1221
        #9 0x56396e2686ba in vty_command lib/vty.c:559
        #10 0x56396e268b54 in vty_execute lib/vty.c:1322
        #11 0x56396e271269 in vtysh_read lib/vty.c:2311
        #12 0x56396e25c5c8 in event_call lib/event.c:1995
        #13 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #14 0x56396e006604 in main ospfd/ospf_main.c:220
        #15 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f03a5a8ad28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x56396e1bf10c in qcalloc lib/memory.c:105
        #2 0x56396e015538 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x56396e01960d in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x56396e0299f5 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x56396e0384b1 in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x56396e04489b in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x56396e04489b in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x56396e25c5c8 in event_call lib/event.c:1995
        #9 0x56396e1a2338 in frr_run lib/libfrr.c:1213
        #10 0x56396e006604 in main ospfd/ospf_main.c:220
        #11 0x7f03a42e6c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9727 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12140/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-12140/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12140/artifact/TOPO8U18ARM64/TopotestDetails/

Report for ospf_vty.c | 20 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3779: FILE: /tmp/f1-149844/ospf_vty.c:3779:
< WARNING: please, no spaces at the start of a line
< #3779: FILE: /tmp/f1-149844/ospf_vty.c:3779:
< ERROR: code indent should use tabs where possible
< #3780: FILE: /tmp/f1-149844/ospf_vty.c:3780:
< WARNING: please, no spaces at the start of a line
< #3780: FILE: /tmp/f1-149844/ospf_vty.c:3780:
< ERROR: code indent should use tabs where possible
< #3781: FILE: /tmp/f1-149844/ospf_vty.c:3781:
< WARNING: please, no spaces at the start of a line
< #3781: FILE: /tmp/f1-149844/ospf_vty.c:3781:
< ERROR: code indent should use tabs where possible
< #3782: FILE: /tmp/f1-149844/ospf_vty.c:3782:
< WARNING: please, no spaces at the start of a line
< #3782: FILE: /tmp/f1-149844/ospf_vty.c:3782:
< WARNING: Missing a blank line after declarations
< #9698: FILE: /tmp/f1-149844/ospf_vty.c:9698:
< WARNING: Missing a blank line after declarations
< #9759: FILE: /tmp/f1-149844/ospf_vty.c:9759:

NetDEF-CI · 2023-06-08T22:05:11Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
ospfd/ospf_flood.c: In function ospf_flood_through_interface:
./lib/zlog.h:109:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type const char * [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
ospfd/ospf_flood.c:574:4: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10532: ospfd/ospf_flood.o] Error 1
/home/ci/cibuild.12156/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.12156/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 22.04 amd64 build
Debian 10 amd64 build
Ubuntu 18.04 arm7 build
Redhat 9 amd64 build
Ubuntu 18.04 amd64 build
FreeBSD 11 amd64 build
FreeBSD 12 amd64 build
CentOS 7 amd64 build
Redhat 8 amd64 build
Ubuntu 18.04 i386 build
OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
ospfd/ospf_flood.c: In function ospf_flood_through_interface:
./lib/zlog.h:109:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 4 has type const char * [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
ospfd/ospf_flood.c:574:4: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10532: ospfd/ospf_flood.o] Error 1
/home/ci/cibuild.12156/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.12156/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12156/artifact/DEB11AMD64/config.status/config.status

Report for ospf_vty.c | 16 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-3948796/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-3948796/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-3948796/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-3948796/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-3948796/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-3948796/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9824: FILE: /tmp/f1-3948796/ospf_vty.c:9824:
< WARNING: Missing a blank line after declarations
< #9885: FILE: /tmp/f1-3948796/ospf_vty.c:9885:

NetDEF-CI · 2023-06-13T21:38:14Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12308/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004547a at pc 0x5606c32e847d bp 0x7ffd6ebe4540 sp 0x7ffd6ebe4530
    READ of size 1 at 0x60c00004547a thread T0
        #0 0x5606c32e847c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5606c32e847c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5606c3380379 in cmd_execute_command_real lib/command.c:994
        #3 0x5606c3380846 in cmd_execute_command lib/command.c:1053
        #4 0x5606c3380cbd in cmd_execute lib/command.c:1221
        #5 0x5606c34a1c2a in vty_command lib/vty.c:559
        #6 0x5606c34a20c4 in vty_execute lib/vty.c:1322
        #7 0x5606c34aa82d in vtysh_read lib/vty.c:2311
        #8 0x5606c3495b38 in event_call lib/event.c:1995
        #9 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #10 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #11 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5606c323eda9 in _start (/usr/lib/frr/ospfd+0x2e1da9)
    
    0x60c00004547a is located 122 bytes inside of 128-byte region [0x60c000045400,0x60c000045480)
    freed by thread T0 here:
        #0 0x7fa13481e7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5606c33f902a in qfree lib/memory.c:130
        #2 0x5606c324e8a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5606c3251c37 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5606c32e8455 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5606c32e8455 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5606c3380379 in cmd_execute_command_real lib/command.c:994
        #7 0x5606c3380846 in cmd_execute_command lib/command.c:1053
        #8 0x5606c3380cbd in cmd_execute lib/command.c:1221
        #9 0x5606c34a1c2a in vty_command lib/vty.c:559
        #10 0x5606c34a20c4 in vty_execute lib/vty.c:1322
        #11 0x5606c34aa82d in vtysh_read lib/vty.c:2311
        #12 0x5606c3495b38 in event_call lib/event.c:1995
        #13 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #14 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #15 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fa13481ed28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5606c33f8696 in qcalloc lib/memory.c:105
        #2 0x5606c324e228 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5606c32522fd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5606c3262753 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5606c327120f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5606c327d5f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5606c327d5f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5606c3495b38 in event_call lib/event.c:1995
        #9 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #10 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #11 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a30: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a40: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000aa0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12308/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12308/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 6
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12308/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004547a at pc 0x5606c32e847d bp 0x7ffd6ebe4540 sp 0x7ffd6ebe4530
    READ of size 1 at 0x60c00004547a thread T0
        #0 0x5606c32e847c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5606c32e847c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5606c3380379 in cmd_execute_command_real lib/command.c:994
        #3 0x5606c3380846 in cmd_execute_command lib/command.c:1053
        #4 0x5606c3380cbd in cmd_execute lib/command.c:1221
        #5 0x5606c34a1c2a in vty_command lib/vty.c:559
        #6 0x5606c34a20c4 in vty_execute lib/vty.c:1322
        #7 0x5606c34aa82d in vtysh_read lib/vty.c:2311
        #8 0x5606c3495b38 in event_call lib/event.c:1995
        #9 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #10 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #11 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5606c323eda9 in _start (/usr/lib/frr/ospfd+0x2e1da9)
    
    0x60c00004547a is located 122 bytes inside of 128-byte region [0x60c000045400,0x60c000045480)
    freed by thread T0 here:
        #0 0x7fa13481e7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5606c33f902a in qfree lib/memory.c:130
        #2 0x5606c324e8a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5606c3251c37 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5606c32e8455 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5606c32e8455 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5606c3380379 in cmd_execute_command_real lib/command.c:994
        #7 0x5606c3380846 in cmd_execute_command lib/command.c:1053
        #8 0x5606c3380cbd in cmd_execute lib/command.c:1221
        #9 0x5606c34a1c2a in vty_command lib/vty.c:559
        #10 0x5606c34a20c4 in vty_execute lib/vty.c:1322
        #11 0x5606c34aa82d in vtysh_read lib/vty.c:2311
        #12 0x5606c3495b38 in event_call lib/event.c:1995
        #13 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #14 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #15 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fa13481ed28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5606c33f8696 in qcalloc lib/memory.c:105
        #2 0x5606c324e228 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5606c32522fd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5606c3262753 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5606c327120f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5606c327d5f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5606c327d5f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5606c3495b38 in event_call lib/event.c:1995
        #9 0x5606c33db8c2 in frr_run lib/libfrr.c:1213
        #10 0x5606c323f2f4 in main ospfd/ospf_main.c:220
        #11 0x7fa13307ac86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a30: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a40: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000aa0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12308/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12308/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12308/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Report for ospf_vty.c | 14 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-695429/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-695429/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-695429/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-695429/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-695429/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-695429/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9822: FILE: /tmp/f1-695429/ospf_vty.c:9822:

odd22 · 2023-06-20T15:24:37Z

Hi Acee,

I have a global remark / concern with your PR. There is many part of the ospf code using Opaque LSA which could be impacted by your change, in particular all features related to TE, Router Information and Segment Routing. All of these particular code maintain an up to date list of interfaces that are enable for TE and SR at least. And this list are not handle this per interface opaque activation. There are looking to the global opaque / mpls configuration at ospf level and for TE, the presence or not of link-param.

I'm afraid that this new configuration will not disable opaque at TE and SR level for this given interface and cause trouble i.e. try to send Opaque LSA on this interface, take into this interface while it should not ...

Can you have a look at ospf_ri.c, ospf_te.c, ospf_ext.c and ospf_sr.c to determine if there is an impact or not with your PR?

Thanks,

Olivier

odd22

Need to evaluate the impact of this PR to other parts of ospf which are using Opaque LSA, in particular, Traffic Engineering, Router Information and Segment Routing

aceelindem · 2023-06-20T19:55:28Z

Hi Olivier,

You are absolutely correct. You don't want to disable opaque LSA support on an interface without understanding the implications. This is for dense flooding topologies where the opaque application generates a lot of opaque LSAs and
the network administrator wants to limit the flooding path (similar to vendor options to disable flooding on select interfaces). I'm adding this to the documentation:

diff --git a/doc/user/ospfd.rst b/doc/user/ospfd.rst
index 037dd6df2..232b1c393 100644
--- a/doc/user/ospfd.rst
+++ b/doc/user/ospfd.rst
@@ -925,7 +925,12 @@ Opaque LSA
Enable or disable OSPF LSA database exchange and flooding on an interface.
The default is that opaque capability is enabled as long as the opaque
capability is enabled with the :clicmd:capability opaque command at the

OSPF instance level (using the command above).

OSPF instance level (using the command above). Note that disabling opaque
LSA support on an interface will impact the applications using opaque LSAs
if the opaque LSAs are not received on other flooding paths by all the
OSPF routers using those applications. For example, OSPF Graceful Restart
uses opaque-link LSAs and disabling support on an interface will disable
graceful restart signaling on that interface.

.. clicmd:: show ip ospf [vrf <NAME|all>] database (opaque-link|opaque-area|opaque-external)

a

NetDEF-CI · 2023-06-20T23:26:48Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12419/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004547a at pc 0x5563a3bfe95d bp 0x7ffdef497070 sp 0x7ffdef497060
    READ of size 1 at 0x60c00004547a thread T0
        #0 0x5563a3bfe95c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5563a3bfe95c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5563a3c96859 in cmd_execute_command_real lib/command.c:994
        #3 0x5563a3c96d26 in cmd_execute_command lib/command.c:1053
        #4 0x5563a3c9719d in cmd_execute lib/command.c:1221
        #5 0x5563a3db82aa in vty_command lib/vty.c:563
        #6 0x5563a3db8744 in vty_execute lib/vty.c:1326
        #7 0x5563a3dc0f4d in vtysh_read lib/vty.c:2328
        #8 0x5563a3dac1b8 in event_call lib/event.c:1995
        #9 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #10 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #11 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5563a3b55289 in _start (/usr/lib/frr/ospfd+0x2e2289)
    
    0x60c00004547a is located 122 bytes inside of 128-byte region [0x60c000045400,0x60c000045480)
    freed by thread T0 here:
        #0 0x7f0b811717a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5563a3d0f50a in qfree lib/memory.c:130
        #2 0x5563a3b64d82 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5563a3b68117 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5563a3bfe935 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5563a3bfe935 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5563a3c96859 in cmd_execute_command_real lib/command.c:994
        #7 0x5563a3c96d26 in cmd_execute_command lib/command.c:1053
        #8 0x5563a3c9719d in cmd_execute lib/command.c:1221
        #9 0x5563a3db82aa in vty_command lib/vty.c:563
        #10 0x5563a3db8744 in vty_execute lib/vty.c:1326
        #11 0x5563a3dc0f4d in vtysh_read lib/vty.c:2328
        #12 0x5563a3dac1b8 in event_call lib/event.c:1995
        #13 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #14 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #15 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f0b81171d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5563a3d0eb76 in qcalloc lib/memory.c:105
        #2 0x5563a3b64708 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5563a3b687dd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5563a3b78c33 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5563a3b876ef in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5563a3b93ad9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5563a3b93ad9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5563a3dac1b8 in event_call lib/event.c:1995
        #9 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #10 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #11 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a30: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a40: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000aa0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12419/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/ASAN9/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 20.04 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Static analyzer (clang)
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12419/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004547a at pc 0x5563a3bfe95d bp 0x7ffdef497070 sp 0x7ffdef497060
    READ of size 1 at 0x60c00004547a thread T0
        #0 0x5563a3bfe95c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5563a3bfe95c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5563a3c96859 in cmd_execute_command_real lib/command.c:994
        #3 0x5563a3c96d26 in cmd_execute_command lib/command.c:1053
        #4 0x5563a3c9719d in cmd_execute lib/command.c:1221
        #5 0x5563a3db82aa in vty_command lib/vty.c:563
        #6 0x5563a3db8744 in vty_execute lib/vty.c:1326
        #7 0x5563a3dc0f4d in vtysh_read lib/vty.c:2328
        #8 0x5563a3dac1b8 in event_call lib/event.c:1995
        #9 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #10 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #11 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5563a3b55289 in _start (/usr/lib/frr/ospfd+0x2e2289)
    
    0x60c00004547a is located 122 bytes inside of 128-byte region [0x60c000045400,0x60c000045480)
    freed by thread T0 here:
        #0 0x7f0b811717a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5563a3d0f50a in qfree lib/memory.c:130
        #2 0x5563a3b64d82 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5563a3b68117 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5563a3bfe935 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5563a3bfe935 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5563a3c96859 in cmd_execute_command_real lib/command.c:994
        #7 0x5563a3c96d26 in cmd_execute_command lib/command.c:1053
        #8 0x5563a3c9719d in cmd_execute lib/command.c:1221
        #9 0x5563a3db82aa in vty_command lib/vty.c:563
        #10 0x5563a3db8744 in vty_execute lib/vty.c:1326
        #11 0x5563a3dc0f4d in vtysh_read lib/vty.c:2328
        #12 0x5563a3dac1b8 in event_call lib/event.c:1995
        #13 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #14 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #15 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f0b81171d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5563a3d0eb76 in qcalloc lib/memory.c:105
        #2 0x5563a3b64708 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5563a3b687dd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5563a3b78c33 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5563a3b876ef in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5563a3b93ad9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5563a3b93ad9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5563a3dac1b8 in event_call lib/event.c:1995
        #9 0x5563a3cf1da2 in frr_run lib/libfrr.c:1213
        #10 0x5563a3b557d4 in main ospfd/ospf_main.c:220
        #11 0x7f0b7f9cdc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a30: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a40: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    =>0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000aa0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12419/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12419/artifact/ASAN9/TopotestDetails/

Report for ospf_vty.c | 14 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-2000591/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-2000591/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-2000591/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-2000591/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-2000591/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-2000591/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9822: FILE: /tmp/f1-2000591/ospf_vty.c:9822:

NetDEF-CI · 2023-06-22T21:26:29Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12472/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x5635d848117d bp 0x7ffc02c539a0 sp 0x7ffc02c53990
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x5635d848117c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5635d848117c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5635d8519082 in cmd_execute_command_real lib/command.c:994
        #3 0x5635d851954f in cmd_execute_command lib/command.c:1053
        #4 0x5635d85199c6 in cmd_execute lib/command.c:1221
        #5 0x5635d863ac1a in vty_command lib/vty.c:591
        #6 0x5635d863b0b4 in vty_execute lib/vty.c:1354
        #7 0x5635d8643893 in vtysh_read lib/vty.c:2362
        #8 0x5635d862eb28 in event_call lib/event.c:1995
        #9 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #10 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #11 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5635d83d7aa9 in _start (/usr/lib/frr/ospfd+0x2e2aa9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f8e8132f7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5635d8591d33 in qfree lib/memory.c:130
        #2 0x5635d83e75a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5635d83ea937 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5635d8481155 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5635d8481155 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5635d8519082 in cmd_execute_command_real lib/command.c:994
        #7 0x5635d851954f in cmd_execute_command lib/command.c:1053
        #8 0x5635d85199c6 in cmd_execute lib/command.c:1221
        #9 0x5635d863ac1a in vty_command lib/vty.c:591
        #10 0x5635d863b0b4 in vty_execute lib/vty.c:1354
        #11 0x5635d8643893 in vtysh_read lib/vty.c:2362
        #12 0x5635d862eb28 in event_call lib/event.c:1995
        #13 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #14 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #15 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f8e8132fd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5635d859139f in qcalloc lib/memory.c:105
        #2 0x5635d83e6f28 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5635d83eaffd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5635d83fb453 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5635d8409f0f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5635d84162f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5635d84162f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5635d862eb28 in event_call lib/event.c:1995
        #9 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #10 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #11 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12472/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/ASAN9/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 7
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12472/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x5635d848117d bp 0x7ffc02c539a0 sp 0x7ffc02c53990
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x5635d848117c in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5635d848117c in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5635d8519082 in cmd_execute_command_real lib/command.c:994
        #3 0x5635d851954f in cmd_execute_command lib/command.c:1053
        #4 0x5635d85199c6 in cmd_execute lib/command.c:1221
        #5 0x5635d863ac1a in vty_command lib/vty.c:591
        #6 0x5635d863b0b4 in vty_execute lib/vty.c:1354
        #7 0x5635d8643893 in vtysh_read lib/vty.c:2362
        #8 0x5635d862eb28 in event_call lib/event.c:1995
        #9 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #10 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #11 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5635d83d7aa9 in _start (/usr/lib/frr/ospfd+0x2e2aa9)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f8e8132f7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5635d8591d33 in qfree lib/memory.c:130
        #2 0x5635d83e75a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5635d83ea937 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5635d8481155 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5635d8481155 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5635d8519082 in cmd_execute_command_real lib/command.c:994
        #7 0x5635d851954f in cmd_execute_command lib/command.c:1053
        #8 0x5635d85199c6 in cmd_execute lib/command.c:1221
        #9 0x5635d863ac1a in vty_command lib/vty.c:591
        #10 0x5635d863b0b4 in vty_execute lib/vty.c:1354
        #11 0x5635d8643893 in vtysh_read lib/vty.c:2362
        #12 0x5635d862eb28 in event_call lib/event.c:1995
        #13 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #14 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #15 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f8e8132fd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5635d859139f in qcalloc lib/memory.c:105
        #2 0x5635d83e6f28 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5635d83eaffd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5635d83fb453 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5635d8409f0f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5635d84162f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5635d84162f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5635d862eb28 in event_call lib/event.c:1995
        #9 0x5635d85745cb in frr_run lib/libfrr.c:1213
        #10 0x5635d83d7ff4 in main ospfd/ospf_main.c:220
        #11 0x7f8e7fb8bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12472/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12472/artifact/ASAN9/TopotestDetails/

Report for ospf_vty.c | 14 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-101168/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-101168/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-101168/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-101168/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-101168/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-101168/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9822: FILE: /tmp/f1-101168/ospf_vty.c:9822:

odd22 · 2023-06-26T16:17:17Z

Hi Olivier,

You are absolutely correct. You don't want to disable opaque LSA support on an interface without understanding the implications. This is for dense flooding topologies where the opaque application generates a lot of opaque LSAs and the network administrator wants to limit the flooding path (similar to vendor options to disable flooding on select interfaces). I'm adding this to the documentation:

diff --git a/doc/user/ospfd.rst b/doc/user/ospfd.rst index 037dd6df2..232b1c393 100644 --- a/doc/user/ospfd.rst +++ b/doc/user/ospfd.rst @@ -925,7 +925,12 @@ Opaque LSA Enable or disable OSPF LSA database exchange and flooding on an interface. The default is that opaque capability is enabled as long as the opaque capability is enabled with the :clicmd:capability opaque command at the

OSPF instance level (using the command above).

OSPF instance level (using the command above). Note that disabling opaque

LSA support on an interface will impact the applications using opaque LSAs

if the opaque LSAs are not received on other flooding paths by all the

OSPF routers using those applications. For example, OSPF Graceful Restart

uses opaque-link LSAs and disabling support on an interface will disable

graceful restart signaling on that interface.

.. clicmd:: show ip ospf [vrf <NAME|all>] database (opaque-link|opaque-area|opaque-external)

a

Hi Acee,

I perfectly understand the use case. What I'm wondering, is the implication of disabling Opaque LSA on an interface with TE, SR & co Looking to the code, TE and SR assume that Opaque is enable or disable globally, not on a per interface. Thus, if you disable Opaque on an interface, Opaque LSA will not be advertise on this interface, but TE and SR are expected to receive/advertise Opaque LSA on this interface. I'm pretty sure that the code will failed in this case.

So, I think this PR must also add some extra verification inside ospf_te.c, ospf_sr.c and ospf_ext.c files to check that Opaque LSA is enabled/disabled before adding the interface in the MPLS, SR and EXT list of managed interface.

Regards

Olivier

odd22

Please add extra verification concerning this new opaque switch per interface inside ospf_te.c, ospf_sr.c and ospf_ext.c to check if this interface should be added or not to the MPLS, SR respectively EXT interface lists

aceelindem · 2023-06-27T15:23:01Z

This configuration option is simply to disable flooding, it has nothing to do with the actual functions that the OSPF opaque LSAs are advertising. I'm not sure what you are asking for but I don't think it makes sense.

NetDEF-CI · 2023-06-27T23:14:49Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12587/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 5: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12587/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12587/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x556f5981f15a bp 0x7ffccaf91830 sp 0x7ffccaf91820
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x556f5981f159 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x556f5981f159 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x556f598b7066 in cmd_execute_command_real lib/command.c:994
        #3 0x556f598b7533 in cmd_execute_command lib/command.c:1053
        #4 0x556f598b79aa in cmd_execute lib/command.c:1221
        #5 0x556f599d8a14 in vty_command lib/vty.c:591
        #6 0x556f599d8eae in vty_execute lib/vty.c:1354
        #7 0x556f599e168d in vtysh_read lib/vty.c:2362
        #8 0x556f599cc922 in event_call lib/event.c:1995
        #9 0x556f599125af in frr_run lib/libfrr.c:1213
        #10 0x556f59775ef4 in main ospfd/ospf_main.c:249
        #11 0x7f2577214c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x556f59775859 in _start (/usr/lib/frr/ospfd+0x2e3859)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7f25789b87a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x556f5992faf0 in qfree lib/memory.c:130
        #2 0x556f597854a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x556f59788837 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x556f5981f132 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x556f5981f132 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x556f598b7066 in cmd_execute_command_real lib/command.c:994
        #7 0x556f598b7533 in cmd_execute_command lib/command.c:1053
        #8 0x556f598b79aa in cmd_execute lib/command.c:1221
        #9 0x556f599d8a14 in vty_command lib/vty.c:591
        #10 0x556f599d8eae in vty_execute lib/vty.c:1354
        #11 0x556f599e168d in vtysh_read lib/vty.c:2362
        #12 0x556f599cc922 in event_call lib/event.c:1995
        #13 0x556f599125af in frr_run lib/libfrr.c:1213
        #14 0x556f59775ef4 in main ospfd/ospf_main.c:249
        #15 0x7f2577214c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f25789b8d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x556f5992f15c in qcalloc lib/memory.c:105
        #2 0x556f59784e28 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x556f59788efd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x556f59799353 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x556f597a7e0f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x556f597b41f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x556f597b41f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x556f599cc922 in event_call lib/event.c:1995
        #9 0x556f599125af in frr_run lib/libfrr.c:1213
        #10 0x556f59775ef4 in main ospfd/ospf_main.c:249
        #11 0x7f2577214c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12587/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12587/artifact/ASAN9/TopotestDetails/

Successful on other platforms/tests

Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 9

NetDEF-CI · 2023-06-28T03:12:17Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12593/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x5580f17f215a bp 0x7fffd0392c30 sp 0x7fffd0392c20
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x5580f17f2159 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5580f17f2159 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5580f1889ff4 in cmd_execute_command_real lib/command.c:994
        #3 0x5580f188a4c1 in cmd_execute_command lib/command.c:1053
        #4 0x5580f188a938 in cmd_execute lib/command.c:1221
        #5 0x5580f19ab994 in vty_command lib/vty.c:591
        #6 0x5580f19abe2e in vty_execute lib/vty.c:1354
        #7 0x5580f19b460d in vtysh_read lib/vty.c:2362
        #8 0x5580f199f8a2 in event_call lib/event.c:1995
        #9 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #10 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #11 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5580f1748859 in _start (/usr/lib/frr/ospfd+0x2e3859)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7fb11ad3f7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5580f1902a7e in qfree lib/memory.c:130
        #2 0x5580f17584a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5580f175b837 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5580f17f2132 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5580f17f2132 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5580f1889ff4 in cmd_execute_command_real lib/command.c:994
        #7 0x5580f188a4c1 in cmd_execute_command lib/command.c:1053
        #8 0x5580f188a938 in cmd_execute lib/command.c:1221
        #9 0x5580f19ab994 in vty_command lib/vty.c:591
        #10 0x5580f19abe2e in vty_execute lib/vty.c:1354
        #11 0x5580f19b460d in vtysh_read lib/vty.c:2362
        #12 0x5580f199f8a2 in event_call lib/event.c:1995
        #13 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #14 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #15 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fb11ad3fd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5580f19020ea in qcalloc lib/memory.c:105
        #2 0x5580f1757e28 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5580f175befd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5580f176c353 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5580f177ae0f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5580f17871f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5580f17871f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5580f199f8a2 in event_call lib/event.c:1995
        #9 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #10 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #11 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12593/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/ASAN9/TopotestDetails/

Successful on other platforms/tests

Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 1
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 2
Static analyzer (clang)
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 1
Debian 9 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 7
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 0
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12593/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_clientapi.py`, test `_tgen`, router `r2`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c00004553a at pc 0x5580f17f215a bp 0x7fffd0392c30 sp 0x7fffd0392c20
    READ of size 1 at 0x60c00004553a thread T0
        #0 0x5580f17f2159 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9845
        #1 0x5580f17f2159 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #2 0x5580f1889ff4 in cmd_execute_command_real lib/command.c:994
        #3 0x5580f188a4c1 in cmd_execute_command lib/command.c:1053
        #4 0x5580f188a938 in cmd_execute lib/command.c:1221
        #5 0x5580f19ab994 in vty_command lib/vty.c:591
        #6 0x5580f19abe2e in vty_execute lib/vty.c:1354
        #7 0x5580f19b460d in vtysh_read lib/vty.c:2362
        #8 0x5580f199f8a2 in event_call lib/event.c:1995
        #9 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #10 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #11 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #12 0x5580f1748859 in _start (/usr/lib/frr/ospfd+0x2e3859)
    
    0x60c00004553a is located 122 bytes inside of 128-byte region [0x60c0000454c0,0x60c000045540)
    freed by thread T0 here:
        #0 0x7fb11ad3f7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5580f1902a7e in qfree lib/memory.c:130
        #2 0x5580f17584a2 in ospf_del_if_params ospfd/ospf_interface.c:561
        #3 0x5580f175b837 in ospf_free_if_params ospfd/ospf_interface.c:594
        #4 0x5580f17f2132 in ip_ospf_capability_opaque_magic ospfd/ospf_vty.c:9836
        #5 0x5580f17f2132 in ip_ospf_capability_opaque ospfd/ospf_vty_clippy.c:1130
        #6 0x5580f1889ff4 in cmd_execute_command_real lib/command.c:994
        #7 0x5580f188a4c1 in cmd_execute_command lib/command.c:1053
        #8 0x5580f188a938 in cmd_execute lib/command.c:1221
        #9 0x5580f19ab994 in vty_command lib/vty.c:591
        #10 0x5580f19abe2e in vty_execute lib/vty.c:1354
        #11 0x5580f19b460d in vtysh_read lib/vty.c:2362
        #12 0x5580f199f8a2 in event_call lib/event.c:1995
        #13 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #14 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #15 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fb11ad3fd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5580f19020ea in qcalloc lib/memory.c:105
        #2 0x5580f1757e28 in ospf_new_if_params ospfd/ospf_interface.c:525
        #3 0x5580f175befd in ospf_get_if_params ospfd/ospf_interface.c:634
        #4 0x5580f176c353 in ospf_network_lsa_new ospfd/ospf_lsa.c:1073
        #5 0x5580f177ae0f in ospf_network_lsa_update ospfd/ospf_lsa.c:1100
        #6 0x5580f17871f9 in nsm_change_state ospfd/ospf_nsm.c:749
        #7 0x5580f17871f9 in ospf_nsm_event ospfd/ospf_nsm.c:847
        #8 0x5580f199f8a2 in event_call lib/event.c:1995
        #9 0x5580f18e553d in frr_run lib/libfrr.c:1213
        #10 0x5580f1748ef4 in main ospfd/ospf_main.c:249
        #11 0x7fb11959bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_vty.c:9845 in ip_ospf_capability_opaque_magic
    Shadow bytes around the buggy address:
      0x0c1880000a50: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a60: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000a70: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000a90: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    =>0x0c1880000aa0: fd fd fd fd fd fd fd[fd]fa fa fa fa fa fa fa fa
      0x0c1880000ab0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000ac0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880000ad0: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
      0x0c1880000ae0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
      0x0c1880000af0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12593/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12593/artifact/ASAN9/TopotestDetails/

Report for ospf_vty.c | 14 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-1038195/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-1038195/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-1038195/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-1038195/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-1038195/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-1038195/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9822: FILE: /tmp/f1-1038195/ospf_vty.c:9822:

Add support for "[no] ip ospf capbility opaque" at the interface level with the default being capability opaque enabled. The command "no ip ospf capability opaque" will disable opaque LSA database exchange and flooding on the interface. A change in configuration will result in the interface being flapped to update our options for neighbors but no attempt will be made to purge existing LSAs as in dense topologies, these may received by neighbors through different interfaces. Topotests are added to test both the configuration and the LSA opaque flooding suppression. Signed-off-by: Acee <aceelindem@gmail.com>

NetDEF-CI · 2023-06-28T20:05:11Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TP4U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-12616/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12616/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO9DEB10AMD64/TopotestDetails/

Static analyzer (clang): Failed (click for details)

Static analyzer (clang): No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TP4U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-12616/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12616/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12616/artifact/TOPO9DEB10AMD64/TopotestDetails/

Static analyzer (clang): Failed (click for details)

Static analyzer (clang): No useful log found

Report for ospf_vty.c | 18 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-1077823/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-1077823/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-1077823/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-1077823/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-1077823/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-1077823/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9823: FILE: /tmp/f1-1077823/ospf_vty.c:9823:
< ERROR: code indent should use tabs where possible
< #9832: FILE: /tmp/f1-1077823/ospf_vty.c:9832:
< WARNING: please, no spaces at the start of a line
< #9832: FILE: /tmp/f1-1077823/ospf_vty.c:9832:

aceelindem · 2023-06-28T20:41:54Z

CI:rerun

NetDEF-CI · 2023-06-28T23:37:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12623/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12623/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 1
Debian 9 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12623/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Report for ospf_vty.c | 18 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-2262839/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-2262839/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-2262839/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-2262839/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-2262839/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-2262839/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9823: FILE: /tmp/f1-2262839/ospf_vty.c:9823:
< ERROR: code indent should use tabs where possible
< #9832: FILE: /tmp/f1-2262839/ospf_vty.c:9832:
< WARNING: please, no spaces at the start of a line
< #9832: FILE: /tmp/f1-2262839/ospf_vty.c:9832:

aceelindem · 2023-06-29T00:06:24Z

CI:rerun

NetDEF-CI · 2023-06-29T03:05:29Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12625/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12625/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12625/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12625/artifact/TOPO3DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 3
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 0
Static analyzer (clang)

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12625/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12625/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12625/artifact/TOPO3DEB10AMD64/TopotestDetails/

Report for ospf_vty.c | 18 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-3360158/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-3360158/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-3360158/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-3360158/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-3360158/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-3360158/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9823: FILE: /tmp/f1-3360158/ospf_vty.c:9823:
< ERROR: code indent should use tabs where possible
< #9832: FILE: /tmp/f1-3360158/ospf_vty.c:9832:
< WARNING: please, no spaces at the start of a line
< #9832: FILE: /tmp/f1-3360158/ospf_vty.c:9832:

aceelindem · 2023-06-29T09:31:08Z

CI:rerun

NetDEF-CI · 2023-06-29T12:53:14Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12640/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf_vty.c | 18 issues
===============================================
< ERROR: code indent should use tabs where possible
< #3835: FILE: /tmp/f1-2853890/ospf_vty.c:3835:
< WARNING: please, no spaces at the start of a line
< #3835: FILE: /tmp/f1-2853890/ospf_vty.c:3835:
< ERROR: code indent should use tabs where possible
< #3836: FILE: /tmp/f1-2853890/ospf_vty.c:3836:
< WARNING: please, no spaces at the start of a line
< #3836: FILE: /tmp/f1-2853890/ospf_vty.c:3836:
< ERROR: code indent should use tabs where possible
< #3837: FILE: /tmp/f1-2853890/ospf_vty.c:3837:
< WARNING: please, no spaces at the start of a line
< #3837: FILE: /tmp/f1-2853890/ospf_vty.c:3837:
< WARNING: Missing a blank line after declarations
< #9823: FILE: /tmp/f1-2853890/ospf_vty.c:9823:
< ERROR: code indent should use tabs where possible
< #9832: FILE: /tmp/f1-2853890/ospf_vty.c:9832:
< WARNING: please, no spaces at the start of a line
< #9832: FILE: /tmp/f1-2853890/ospf_vty.c:9832:

riw777

looks good

frrbot bot added the ospf label Jun 5, 2023

github-actions bot added master size/XL labels Jun 5, 2023

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 2e2becb to 269a40a Compare June 5, 2023 23:33

rgirada suggested changes Jun 6, 2023

View reviewed changes

ospfd/ospf_vty.c Outdated Show resolved Hide resolved

ospfd/ospf_vty.c Outdated Show resolved Hide resolved

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 269a40a to c9ace7b Compare June 6, 2023 17:26

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from c9ace7b to 4c1f33c Compare June 6, 2023 20:54

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 4c1f33c to ccd9c46 Compare June 7, 2023 13:34

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from ccd9c46 to c03c81c Compare June 7, 2023 18:21

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from c03c81c to 6000858 Compare June 8, 2023 15:48

github-actions bot added the conflicts label Jun 8, 2023

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 6000858 to c96be3e Compare June 8, 2023 21:32

github-actions bot removed the conflicts label Jun 8, 2023

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch 4 times, most recently from 0858029 to 7479595 Compare June 9, 2023 16:40

odd22 requested changes Jun 20, 2023

View reviewed changes

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 86ff92f to 219386d Compare June 20, 2023 20:14

github-actions bot added the rebase PR needs rebase label Jun 20, 2023

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 219386d to f96bd0e Compare June 22, 2023 18:31

odd22 requested changes Jun 26, 2023

View reviewed changes

aceelindem closed this Jun 27, 2023

aceelindem reopened this Jun 27, 2023

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from f96bd0e to 3b11184 Compare June 27, 2023 20:09

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from 3b11184 to a4bfd62 Compare June 28, 2023 00:10

aceelindem force-pushed the aceelindem/ospf-opaque-interface-disable branch from a4bfd62 to e72549c Compare June 28, 2023 17:04

riw777 self-requested a review July 11, 2023 15:45

riw777 approved these changes Jul 11, 2023

View reviewed changes

riw777 merged commit 6e89a5d into FRRouting:master Jul 11, 2023
5 checks passed

ospfd: Configurable interface-level 'capability opaque' support #13691

ospfd: Configurable interface-level 'capability opaque' support #13691

Conversation

aceelindem commented Jun 5, 2023

NetDEF-CI commented Jun 5, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

aceelindem commented Jun 5, 2023

NetDEF-CI commented Jun 6, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

3 Static Analyzer issues remaining.

NetDEF-CI commented Jun 6, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

3 Static Analyzer issues remaining.

rgirada commented Jun 6, 2023

NetDEF-CI commented Jun 6, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 6, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

aceelindem commented Jun 7, 2023

NetDEF-CI commented Jun 7, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 7, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

github-actions bot commented Jun 8, 2023

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

odd22 commented Jun 20, 2023

odd22 left a comment

Choose a reason for hiding this comment

aceelindem commented Jun 20, 2023

NetDEF-CI commented Jun 20, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 5, 2023 •

edited

Loading

NetDEF-CI commented Jun 6, 2023 •

edited

Loading

NetDEF-CI commented Jun 6, 2023 •

edited

Loading

NetDEF-CI commented Jun 6, 2023 •

edited

Loading

NetDEF-CI commented Jun 6, 2023 •

edited

Loading

NetDEF-CI commented Jun 7, 2023 •

edited

Loading

NetDEF-CI commented Jun 7, 2023 •

edited

Loading

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

NetDEF-CI commented Jun 20, 2023 •

edited

Loading

NetDEF-CI commented Jun 22, 2023 •

edited

Loading

NetDEF-CI commented Jun 27, 2023 •

edited

Loading

NetDEF-CI commented Jun 28, 2023 •

edited

Loading

NetDEF-CI commented Jun 28, 2023 •

edited

Loading