-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Ensure peer data structure is accessed only when BGPD is not te… #13870
Conversation
…rminating With these changes, the code ensures that the peer data-structures are accessed only after it knows that BGPD is not terminating. Authored-by: Naveen Thanikachalam <nthanikachal@vmware.com> Signed-off-by: Iqra Siddiqui <imujeebsiddi@vmware.com>
Just for the understanding: how did you catch this? |
@Mergifyio backport dev/9.0 |
✅ Backports have been created
|
Hi Donatas, This came as an internal review comment (received as part of downstreaming 97b4a0e). |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-12603/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12603/ This is a comment from an automated CI system. |
bgpd: Ensure peer data structure is accessed only when BGPD is not te… (backport #13870)
Ensure peer data structure is accessed only when BGPD is not terminating.
With these changes,
the code ensures that the peer data-structures are accessed only after it knows that BGPD is not terminating.
Authored-by: Naveen Thanikachalam nthanikachal@vmware.com
Signed-off-by: Iqra Siddiqui imujeebsiddi@vmware.com