Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix show route map JSON display #14856

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

rzalamena
Copy link
Member

Fixes #13515 .

This PR moves the show route-map daemon output aggregation to vtysh so we can properly format the JSON output. It also removes a zebra lingering documentation that duplicates the one found in route-map docs.

@ton31337
Copy link
Member

@Mergifyio backport stable/9.1 stable/9.0 stable/8.5

Copy link

mergify bot commented Nov 22, 2023

backport stable/9.1 stable/9.0 stable/8.5

✅ Backports have been created

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of chips (non-blocking) from my side :)

vtysh/vtysh.c Show resolved Hide resolved
vtysh/vtysh.c Outdated Show resolved Hide resolved
Move the command from 'lib' to 'vtysh' so we can properly format the
JSON output in a correct manner.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Remove zebra duplicated command documentation without description.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit a526795 into FRRouting:master Nov 28, 2023
78 checks passed
donaldsharp added a commit that referenced this pull request Nov 28, 2023
lib: fix show route map JSON display (backport #14856)
donaldsharp added a commit that referenced this pull request Nov 28, 2023
lib: fix show route map JSON display (backport #14856)
donaldsharp added a commit that referenced this pull request Nov 28, 2023
lib: fix show route map JSON display (backport #14856)
@rzalamena rzalamena deleted the show-rm branch January 12, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JSON output of show route-map [WORD] json
4 participants