Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake install prefix #15737

Merged
merged 3 commits into from
Apr 26, 2024
Merged

cmake install prefix #15737

merged 3 commits into from
Apr 26, 2024

Conversation

vjardin
Copy link
Contributor

@vjardin vjardin commented Apr 14, 2024

Since cmake 3.21, we should use --install-prefix
see https://cmake.org/cmake/help/latest/manual/cmake.1.html

ton31337
ton31337 reviewed Apr 14, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a NOTE about this "recommendation" from the specific version?

@vjardin
Copy link
Contributor Author

vjardin commented Apr 14, 2024

3.21 was released back to 2021:
Kitware/CMake@ff7a2e3

I am concerned about an over complex documentation to be maintained if we keep a note for the old build frameworks.

Moreover, it won't be lost since the former FRR docs will still be available.

@ton31337
Copy link
Member

ci:rerun something went wrong

@vjardin
docs: libyang install-prefix since cmake 3.21
e779a5f 
use the new recommendation from cmake:
  --install-prefix <directory>
     New in version 3.21.

     Specify the installation directory, used by the
     CMAKE_INSTALL_PREFIX variable. Must be an
     absolute path.

reminder: the default path is /usr/local instead of /usr

Signed-off-by: Vincent Jardin <vjardin@free.fr>
@vjardin
docs: sysrepo install-prefix since cmake 3.21
b916193 
use the new recommendation from cmake:
  --install-prefix <directory>
     New in version 3.21.

     Specify the installation directory, used by the
     CMAKE_INSTALL_PREFIX variable. Must be an
     absolute path.

reminder: the default path is /usr/local instead of /usr

Signed-off-by: Vincent Jardin <vjardin@free.fr>
@vjardin
docs: libs install-prefix since cmake 3.21
f30275d 
use the new recommendation from cmake:
  --install-prefix <directory>
     New in version 3.21.

     Specify the installation directory, used by the
     CMAKE_INSTALL_PREFIX variable. Must be an
     absolute path.

reminder: the default path is /usr/local instead of /usr

Signed-off-by: Vincent Jardin <vjardin@free.fr>
@vjardin
Copy link
Contributor Author

vjardin commented Apr 26, 2024

ci:rerun

This pull request is just about some typos and contents into the documentation.



    TopoTests Debian 10 amd64 Part 1 -> https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO1DEB10AMD64-2901
    🚫 bfd_topo3.test_bfd_topo3 test_wait_bfd_convergence

E   AssertionError: "r1" BFD configuration failure
   assert Generated JSON diff error report:
     
     > $: output has Array of length 2 but in expected it is of length 3

@ton31337 ton31337 merged commit 524e08c into FRRouting:master Apr 26, 2024
8 of 9 checks passed
@vjardin vjardin deleted the cmake_install_prefix branch April 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

Assignees
No one assigned
Labels
master size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjardin @ton31337