zebra: fix update nexthop-group fib flag value #16332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the before and after output looks the same to me. Can you fix or better highlight what I am missing? |
donaldsharp
requested changes
Jul 2, 2024
zebra/zebra_nhg.c
Outdated
| continue; | ||
| if (CHECK_FLAG(nhop->flags, NEXTHOP_FLAG_RECURSIVE)) | ||
| continue; | ||
| SET_FLAG(nhop->flags, NEXTHOP_FLAG_FIB); |
There was a problem hiding this comment.
I want this flag set after we receive the correct response from the kernel / dplane that it has been properly installed. This is not the correct place to make this change. I thought we already did this though, so I am a bit confused here as well.
There was a problem hiding this comment.
Moved at the place where zebra_nhg_handle_install() is called.
This is for nexthop-groups. I have some issues with duplicate flag.
(see #16028 )
pguibert6WIND
force-pushed
the
nexthop_group_update_fib_flag
branch
from
567c57b
to
257b34a
Compare
pguibert6WIND
force-pushed
the
nexthop_group_update_fib_flag
branch
from
257b34a
to
589e240
Compare
|
@Mergifyio backport dev/10.1 |
🟠 Waiting for conditions to match
|
|
@chiragshah6 , any feedback ? |
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 5, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
expected:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Fix this by refreshing the fib flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 5, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
expected:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Fix this by refreshing the fib flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 7, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
expected:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Fix this by refreshing the fib flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
nexthop_group_update_fib_flag
branch
2 times, most recently
from
e1a9b08
to
731f74e
Compare
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
nexthop_group_update_fib_flag
branch
from
731f74e
to
21722d9
Compare
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 8, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 10, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Jul 11, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
@Mergifyio backport stable/10.1 |
🟠 Waiting for conditions to match
|
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Sep 9, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Sep 10, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Sep 10, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Sep 27, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Sep 30, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Oct 1, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
added a commit
to pguibert6WIND/frr
that referenced
this pull request
Oct 2, 2024
A nexthop-group does not display the 'fib' flag
value of its nexthops.
> nexthop-group A
> nexthop 192.168.1.55 loop1
> exit
observed:
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:17",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 528
> ],
> "nexthops":[
> {
> "flags":1,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
The FIB flag is used to inform the user that a given nexthop
is installed in the system, which is the case when using
iproute2:
> # ip nexthop show id 181818168
> id 181818168 group 15 proto 194
> # ip nexthop show id 15
> id 15 via 192.168.1.55 dev loop1 scope link proto 194
Fix this by refreshing the FIB flag value of its nexthops,
when the dataplane result indicate the nexthop-group is
installed.
> ubuntu2204# show nexthop-group rib 181818168 json
> {
> "181818168":{
> "type":"sharp",
> "refCount":1,
> "uptime":"00:00:25",
> "vrf":"default",
> "valid":true,
> "installed":true,
> "depends":[
> 574
> ],
> "nexthops":[
> {
> "flags":3,
> "fib":true,
> "ip":"192.168.1.55",
> "afi":"ipv4",
> "interfaceIndex":3,
> "interfaceName":"loop1",
> "vrf":"default",
> "active":true,
> "weight":1
> }
> ]
> }
> }
>
Link: FRRouting#16332
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nexthop-group does not display the 'fib' flag
value of its nexthops.
observed:
expected:
Fix this by refreshing the fib flag value of its nexthops, when the dataplane result indicate the nexthop-group is installed.