zebra: Do not forget to free opaque data for route entry #16576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Aug 13, 2024
zebra/zebra_rib.c
Outdated
| @@ -4319,6 +4316,7 @@ struct route_entry *zebra_rib_route_entry_new(vrf_id_t vrf_id, int type, | |||
|
|
|||
| void zebra_rib_route_entry_free(struct route_entry *re) | |||
| { | |||
| zapi_re_opaque_free(re->opaque); | |||
There was a problem hiding this comment.
could we NULL that pointer too? it looks like there aren't a lot of callers to that function - maybe it could just take the re and do what's needed?
|
Love this idea - just had one question |
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
fix/free_opaque_data_of_route_entry
branch
from
32b9c30
to
1e288c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.