tests: Fix frequent ospfv3 basic functionality test failure #16657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabahr
approved these changes
Aug 26, 2024
aceelindem
reviewed
Aug 26, 2024
Only if we care about neighbors. However, in that case we only need to make sure we can configure the value 65535, and the following test makes sure we can't configure 65536. |
Ok - I guess the test is only for successful configuration. |
aceelindem
approved these changes
Aug 26, 2024
The dead timer is set to 4 seconds, while the hello interval is set to 6535.
This test will only pass of the platform is fast enough for ospfv3 to
converge in 4 seconds. These timers were already tested multiple time earlier.
This test should just make sure that the boundary value 65535 is configurable,
Other changes in this commit:
- add sequence numbers to the dead intervals tests to make it easier to
track test faliures.
- swap the config order in one test to match order with all other tests.
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
Jafaral
force-pushed
the
ospfv3_test_fix
branch
from
f8a227a
to
0d74574
Compare
|
forced push style issues. |
Jafaral
added a commit
to Jafaral/frr
that referenced
this pull request
Aug 27, 2024
…RRouting#16657) Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
Jafaral
added a commit
to Jafaral/frr
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
Jafaral
added a commit
to Jafaral/frr
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
riw777
added a commit
that referenced
this pull request
Aug 27, 2024
tests: Fix ospfv3 basic functionality test (backport #16657)
riw777
added a commit
that referenced
this pull request
Aug 27, 2024
tests: Fix ospfv3 basic functionality test (backport #16657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dead timer is set to 4 seconds, while the hello interval is set to 6535. This test will only pass if the platform is fast enough for ospfv3 to converge in 4 seconds. These timers were already tested multiple time earlier. This test should just make sure that the boundary value 65535 is configurable,
Other changes in this commit: