4.0: bgpd: don't use BGP_ATTR_VNC(255) unless ENABLE_BGP_VNC_ATTR is defined

[louberger]

Summary

Add ENABLE_BGP_VNC_ATTR check to use of BGP_ATTR_VNC(255) , off by default.

Components

bgpd

[louberger]

:ci:rerun

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6331/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6331/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: shared-lib-without-dependency-information usr/lib/libfrrfpm_pb.so.0.0.0
N: 6 tags overridden (5 warnings, 1 info)

---

CLANG Static Analyzer Summary

• Github Pull Request 3579, comparing to Git base SHA efa1185

No Changes in Static Analysis warnings compared to base

38 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6331/artifact/shared/static_analysis/index.html