Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Increase some wait time in tests #6044

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

donaldsharp
Copy link
Member

The bfd-bgp-cbit-topo3 test is testing bfd timers
with some timers that only wait 4 seconds. The CI
system is failing in various places due to bfd
not converging properly. Upon logging into a
CI system and running tests with intensive disk i/o
I was able to make the tests fail repeatedly in
a couple of different places. Add some additional
time to allow the system to converge on our CI
systems that are running in vm's and may not
always have complete control of cpu's.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

The bfd-bgp-cbit-topo3 test is testing bfd timers
with some timers that only wait 4 seconds.  The CI
system is failing in various places due to bfd
not converging properly.  Upon logging into a
CI system and running tests with intensive disk i/o
I was able to make the tests fail repeatedly in
a couple of different places.  Add some additional
time to allow the system to converge on our CI
systems that are running in vm's and may not
always have complete control of cpu's.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@polychaeta polychaeta added the tests Topotests, make check, etc label Mar 19, 2020
@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 19, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6044 3330837
Date 03/19/2020
Start 08:30:27
Finish 08:56:18
Run-Time 25:51
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-03-19-08:30:27.txt
Log autoscript-2020-03-19-08:31:24.log.bz2
Memory 486 472 418

For details, please contact louberger

@donaldsharp
Copy link
Member Author

This change stopped a test failure:

build	19-Mar-2020 05:52:58	bfd-bgp-cbit-topo3/test_bfd_bgp_cbit_topo3.py::test_bfd_comes_back_again 2020-03-19 12:52:58,551 INFO: re-adding IPv6 address from r2 to simulate connectivity is back
build	19-Mar-2020 05:52:58	2020-03-19 12:52:58,668 INFO: waiting for BFD to converge up
build	19-Mar-2020 05:52:58	2020-03-19 12:52:58,668 INFO: 'router_json_cmp' polling started (interval 0.5 secs, maximum wait 8 secs)
build	19-Mar-2020 05:53:03	2020-03-19 12:53:03,735 INFO: 'router_json_cmp' succeeded after 5.07 seconds
build	19-Mar-2020 05:53:03	2020-03-19 12:53:03,735 INFO: 'router_json_cmp' polling started (interval 0.5 secs, maximum wait 8 secs)
build	19-Mar-2020 05:53:03	2020-03-19 12:53:03,848 INFO: 'router_json_cmp' succeeded after 0.11 seconds```

@donaldsharp
Copy link
Member Author

I believe we'll need to watch this closely

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11294/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200319-01-g33308371d-0 (missing) -> 7.4-dev-20200319-01-g33308371d-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200319-01-g33308371d-0 (missing) -> 7.4-dev-20200319-01-g33308371d-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200319-01-g33308371d-0 (missing) -> 7.4-dev-20200319-01-g33308371d-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200319-01-g33308371d-0 (missing) -> 7.4-dev-20200319-01-g33308371d-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200319-01-g33308371d-0 (missing) -> 7.4-dev-20200319-01-g33308371d-0~deb10u1

@mjstapp mjstapp merged commit 795fbef into FRRouting:master Mar 19, 2020
@donaldsharp donaldsharp deleted the bfd_increase_timers_in_test branch July 8, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants