lib: fix route map description memory leak #6681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
|
LGTM I'll push in once CI finishes |
qlyoung
reviewed
Jul 6, 2020
lib/routemap.c
Outdated
| @@ -971,6 +971,10 @@ void route_map_index_delete(struct route_map_index *index, int notify) | |||
| zlog_debug("Deleting route-map %s sequence %d", | |||
| index->map->name, index->pref); | |||
|
|
|||
| /* Free route map entry description. */ | |||
| if (index->description) | |||
Route map entries are not getting a chance to call `description` string deallocation on shutdown or when the parent entry is destroyed, so lets add a code to handle this in the `route_map_index_delete` function. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
rzalamena
force-pushed
the
rmap-desc-leak-fix
branch
from
0f626a2
to
f095133
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12972/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12974/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6659 .
Route map entries are not getting a chance to call
descriptionstringdeallocation on shutdown or when the parent entry is destroyed, so lets
add a code to handle this in the
route_map_index_deletefunction.This PR might need to be backported to 7.4.