Add Dockerfile #80
Add Dockerfile #80
Conversation
|
|
Dockerfile
Outdated
| RUN go mod download | ||
|
|
||
| COPY . . | ||
| RUN go build -a -o pluto *.go |
There was a problem hiding this comment.
There are more flags necessary here to make it build like the normal binary. In particular, you'll want -s and -w, as well as passing the version and commit as build args.
Line 12 in 81c8d32
There was a problem hiding this comment.
Another example in Goldilocks:
https://github.com/FairwindsOps/goldilocks/blob/master/Dockerfile
There was a problem hiding this comment.
Ahh nice, didn't see the make file. I'm just running make build-linux now. Do I need to pass in VERSION etc?
Also looks like there's a build-docker already, seems to be working
There was a problem hiding this comment.
I think you'll need to add the ARG directive to the dockerfile so that it gets picked up on build to make the build-docker work.
There was a problem hiding this comment.
Oh cool, I'd never seen ARG before. Did I do it right?
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 6 6
Lines 372 372
=======================================
Hits 292 292
Misses 53 53
Partials 27 27 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks like you'll need the build-arg:
└─ docker run quay.io/fairwinds/pluto:build_377 /pluto version
Version:local-dev Commit:e020c9b98796232c37daedae0a6879d7775c13ad
Also, you may want to add an entrypoint or a command so that the dockerfile just runs the binary by default.
Edit: Actually, not sure about the build arg. Forgot I wasn't building a tag.
No description provided.