Add FastDoubleParser section to NOTICE
#1003
Conversation
| under the following copyright. | ||
|
|
||
| Copyright © 2023 Werner Randelshofer, Switzerland. MIT License. |
There was a problem hiding this comment.
Techincally speaking, the copyright is <YEAR> <COPYRIGHT HOLDER>. The current license does not mention 2023 Werner Randelshofer, Switzerland
There was a problem hiding this comment.
his source headers have this - so I'd prefer to err on the side of caution
Hopefully, Werner will update the LICENSE text to include this copyright too and I will then adjust the FastDoubleParser-LICENSE file that I have created here to match any changes to the one in FastDoubleParser project.
There was a problem hiding this comment.
In practice, if Werner includes the proper license file, then you'll get it automatically when shading FastDoubleParser. Then it would be easier for you to maintain since you could count on FDP to ship the up-to-date license always.
That is the reason why I ask projects to ship their license texts under META-INF/.
There was a problem hiding this comment.
If you hard-code 2023 here, you'll have a hard time maintaining the proper copyright header 🤷
There was a problem hiding this comment.
It could have form of 2023+ (or such), does not need to be updated every year.
If adding license straight as part of shading that'd be nice of course but I don't think we have to get super clever here. The intent of license matters, not just specific form.
There was a problem hiding this comment.
I intend to update this once we can get changes made in Fastdoubleparser license file. This PR means Jackson is not blocked from making releases. We can put a more permanent solution in place when next fastdoubleparser release is done.
|
I think we need this starting with branch |
pjfanning
force-pushed
the
fastdoubleparser-license
branch
from
ee30fb6
to
28947b0
Compare
|
@cowtowncoder rebased to v2.15 - I can provide a separate one for the v2.14 - the text will need to be a little different there - eg the copyright year |
|
@pjfanning Sounds good to me. I can merge this now, push forward to 2.16, master. |
cowtowncoder
changed the title
NOTICE
|
Thank you for doing this @pjfanning. Separate PR for 2.14 would be great as I am planning on releasing 2.14.3 relatively soon (accumulated patches, now that 2.15.x is out). But I can make sure this license clarification gets in as well. |
A potential solution to #1002