Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log WARN if deprecated subclasses of PropertyNamingStrategy is used #4144

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Log WARN if deprecated subclasses of PropertyNamingStrategy is used #4144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion src/main/java/com/fasterxml/jackson/databind/PropertyNamingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
import com.fasterxml.jackson.databind.introspect.AnnotatedParameter;

import java.util.logging.Logger;

/**
* Class that defines how names of JSON properties ("external names")
* are derived from names of POJO methods and fields ("internal names"),
Expand Down Expand Up @@ -318,6 +320,14 @@ public String translate(String input)
@Deprecated // since 2.12
public static class UpperCamelCaseStrategy extends PropertyNamingStrategyBase
{
public UpperCamelCaseStrategy() {
Logger.getLogger(UpperCamelCaseStrategy.class.getName())
.warning(
"PropertyNamingStrategy.UpperCamelCaseStrategy is used but it has been deprecated due to " +
"risk of deadlock. Consider using PropertyNamingStrategies.UpperCamelCaseStrategy instead. " +
"See https://github.com/FasterXML/jackson-databind/issues/2715 for more details.");
}

/**
* Converts camelCase to PascalCase
*
Expand Down Expand Up @@ -353,6 +363,14 @@ public String translate(String input) {
@Deprecated // since 2.12
public static class LowerCaseStrategy extends PropertyNamingStrategyBase
{
public LowerCaseStrategy() {
Logger.getLogger(LowerCaseStrategy.class.getName())
.warning(
"PropertyNamingStrategy.LowerCaseStrategy is used but it has been deprecated " +
"due to risk of deadlock. Consider using PropertyNamingStrategies.LowerCaseStrategy instead. " +
"See https://github.com/FasterXML/jackson-databind/issues/2715 for more details.");
}

@Override
public String translate(String input) {
return input.toLowerCase();
Expand All @@ -368,6 +386,14 @@ public String translate(String input) {
@Deprecated // since 2.12
public static class KebabCaseStrategy extends PropertyNamingStrategyBase
{
public KebabCaseStrategy() {
Logger.getLogger(KebabCaseStrategy.class.getName())
.warning(
"PropertyNamingStrategy.KebabCaseStrategy is used but it has been deprecated" +
"due to risk of deadlock. Consider using PropertyNamingStrategies.KebabCaseStrategy instead. " +
"See https://github.com/FasterXML/jackson-databind/issues/2715 for more details.");
}

@Override
public String translate(String input) {
return translateLowerCaseWithSeparator(input, '-');
Expand All @@ -381,7 +407,16 @@ public String translate(String input) {
* for reason for deprecation)
*/
@Deprecated // since 2.12
public static class LowerDotCaseStrategy extends PropertyNamingStrategyBase {
public static class LowerDotCaseStrategy extends PropertyNamingStrategyBase
{
public LowerDotCaseStrategy() {
Logger.getLogger(LowerDotCaseStrategy.class.getName())
.warning(
"PropertyNamingStrategy.LowerDotCaseStrategy is used but it has been deprecated" +
"due to risk of deadlock. Consider using PropertyNamingStrategies.LowerDotCaseStrategy instead. " +
"See https://github.com/FasterXML/jackson-databind/issues/2715 for more details.");
}

@Override
public String translate(String input){
return translateLowerCaseWithSeparator(input, '.');
Expand Down
1 change: 1 addition & 0 deletions src/moditect/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Generated 08-Mar-2019 using Moditect maven plugin
module com.fasterxml.jackson.databind {
requires java.logging;
// required for
// java.beans.ConstructorProperties
// java.beans.Transient
Expand Down