Remove 4 deprecated (in 2.7) PropertyNamingStrategy aliases #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
deleted the
tatu/2.16/rm-2.7-deprecated-propertynamestrategies
branch
6 tasks
MarkEWaite
added a commit
to MarkEWaite/gitlab-plugin
that referenced
this pull request
Jan 2, 2024
Needed for the Jackson 2.16.1-373.ve709c6871598 release that removes Jackson 2 API constants used by this plugin. jenkinsci#1605 notes that the CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES constant needs to be replaced with SNAKE_CASE. FasterXML/jackson-databind#4162 removed those deprecated aliases in FasterXML/jackson-databind@d7a1efc This change is preparation for a dependency on Jackson 2 API 2.16.1.
MarkEWaite
added a commit
to jenkinsci/gitlab-plugin
that referenced
this pull request
Jan 3, 2024
Needed for the Jackson 2.16.1-373.ve709c6871598 release that removes Jackson 2 API constants used by this plugin. #1605 notes that the CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES constant needs to be replaced with SNAKE_CASE. FasterXML/jackson-databind#4162 removed those deprecated aliases in FasterXML/jackson-databind@d7a1efc This change is preparation for a dependency on Jackson 2 API 2.16.1.
MarkEWaite
added a commit
to MarkEWaite/gitee-plugin
that referenced
this pull request
Jan 3, 2024
Upgrades from Jackson 2 API 2.15.2 to Jackson 2 API 2.16.1 so that the API deletion is visible. A Jenkins controller with the Jackson 2 API plugin 2.16.1-373.ve709c6871598 installed may already make this change visible to a gitee plugin without any change to the plugin source code. FasterXML/jackson-databind#4162 removed the constants from the Jackson 2 API after a long period of deprecation. Similar change was needed in the GitLab plugin and is implemented in jenkinsci/gitlab-plugin#1606 The gitee plugin and the GitLab plugin appear to be the only two Jenkins plugins using this constant, per a GitHub search.
MarkEWaite
added a commit
to MarkEWaite/repository-permissions-updater
that referenced
this pull request
Jan 3, 2024
jenkinsci/gitee-plugin#4 is the pull request that I want to merge and release. The Jackson 2 API plugin 2.16.1 has removed two constants that were deprecated long ago. The removal of those constants will break compilation of the gitee plugin and are expected to break runtime of the gitee plugin as well. The targeted pull request upgrades from Jackson 2 API 2.15.2 to Jackson 2 API 2.16.1 so that the API deletion of the constants is visible at compile time. A Jenkins controller with the Jackson 2 API plugin 2.16.1-373.ve709c6871598 installed may already make this change visible to a gitee plugin at run time without any change to the plugin source code. FasterXML/jackson-databind#4162 removed the constants from the Jackson 2 API after a long period of deprecation. The changes were released in Jackson databind 2.16.0 and first included in the matching Jenkins API plugin 2.16.1-373.ve709c6871598. A similar change was needed in the GitLab plugin and is implemented in jenkinsci/gitlab-plugin#1606. If @yashin-luo merges that pull request and releases the gitee plugin, then I don't need to be added as a maintainer. I've started this pull request just in case @yashin-luo is not available and I need to wait two weeks for plugin adoption. https://issues.jenkins.io/browse/JENKINS-72482 is the bug report.
MarkEWaite
added a commit
to jenkinsci/gitee-plugin
that referenced
this pull request
Jan 4, 2024
* [JENKINS-72482] Replace the deleted Jackson 2 API constants Upgrades from Jackson 2 API 2.15.2 to Jackson 2 API 2.16.1 so that the API deletion is visible. A Jenkins controller with the Jackson 2 API plugin 2.16.1-373.ve709c6871598 installed may already make this change visible to a gitee plugin without any change to the plugin source code. FasterXML/jackson-databind#4162 removed the constants from the Jackson 2 API after a long period of deprecation. Similar change was needed in the GitLab plugin and is implemented in jenkinsci/gitlab-plugin#1606 The gitee plugin and the GitLab plugin appear to be the only two Jenkins plugins using this constant, per a GitHub search. * Add more findbugs/spotbugs exclusions * Fail if new findbugs/spotbugs errors are introduced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.