Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treeToValue extensions function should not have type erasure #497

Merged
merged 3 commits into from
Sep 8, 2021
Merged

treeToValue extensions function should not have type erasure #497

merged 3 commits into from
Sep 8, 2021

Conversation

Fuud
Copy link
Contributor

@Fuud Fuud commented Sep 1, 2021

It is fix for #496 and #45

@dinomite dinomite self-assigned this Sep 1, 2021
@dinomite dinomite linked an issue Sep 1, 2021 that may be closed by this pull request
objectMapper.treeToValue is error-prone, should be either deprecated or fixed (or removed?) #496
Closed
@dinomite
Copy link
Member

dinomite commented Sep 1, 2021

This looks great—would you add some tests? Your example from #496 is a good starting point.

If you can do that and send a signed CLA to info at fasterxml dot com I can get this merged. Oh, add a line in the CREDITS file for yourself, too.

@dinomite dinomite added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Sep 1, 2021
@Fuud
Copy link
Contributor Author

Fuud commented Sep 3, 2021

@dinomite CLA sent, CREDITS updated, test added

@dinomite
Copy link
Member

dinomite commented Sep 3, 2021

@cowtowncoder Would you confirm CLA receipt?

@cowtowncoder
Copy link
Member

I can confirm that CLA is received. Thanks!

@Fuud
Copy link
Contributor Author

Fuud commented Sep 8, 2021

@dinomite any updates?

@dinomite
Copy link
Member

dinomite commented Sep 8, 2021

Thanks for the prod, getting back to this now…

@dinomite dinomite merged commit 48d9104 into FasterXML:2.13 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinomite dinomite dinomite approved these changes

Assignees

@dinomite dinomite

Labels
cla-needed PR looks good (although may also require code review), but CLA needed from submitter enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

objectMapper.treeToValue is error-prone, should be either deprecated or fixed (or removed?)
3 participants
@Fuud @dinomite @cowtowncoder