Skip to content

Commit

Permalink
Fix #82 by commenting out black magic that test was doing to try to v…
Browse files Browse the repository at this point in the history
…erify name of generated (de)serializer
  • Loading branch information
cowtowncoder committed Sep 29, 2019
1 parent 27030d4 commit b96ccd2
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.fasterxml.jackson.module.afterburner.deser;

import java.lang.reflect.Field;
import java.util.List;
import java.util.Vector;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
Expand Down Expand Up @@ -145,10 +143,6 @@ static class Issue60Pojo {
public List<Object> foos;
}

static class CheckGeneratedDeserializerName {
public String stringField;
}

/*
/**********************************************************************
/* Test methods, method access
Expand Down Expand Up @@ -331,6 +325,15 @@ public void testProblemWithIndentation() throws Exception {
assertEquals(0, pojo.foos.size());
}

// 28-Sep-2019, tatu: I do not fully understand what this method tried to do;
// it seemed to be a contribution from July 2016. But I noticed that it breaks
// with JDK 12 and unlikely to be allowed so let's comment it out.
/*
static class CheckGeneratedDeserializerName {
public String stringField;
}
@SuppressWarnings("unchecked")
public void testGeneratedDeserializerName() throws Exception {
MAPPER.readValue("{\"stringField\":\"foo\"}", CheckGeneratedDeserializerName.class);
Expand All @@ -355,4 +358,5 @@ public void testGeneratedDeserializerName() throws Exception {
}
fail("Expected class not found:" + expectedClassName);
}
*/
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.fasterxml.jackson.module.afterburner.ser;

import java.lang.reflect.Field;
import java.util.Vector;

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
Expand Down Expand Up @@ -115,10 +112,6 @@ public static class BooleansBean {
public boolean getB() { return false; }
}

static class CheckGeneratedSerializerName {
public String stringField;
}

/*
/**********************************************************************
/* Test methods, method access
Expand Down Expand Up @@ -211,6 +204,15 @@ public void testFiveMinuteDoc() throws Exception
assertEquals(jsonPlain, jsonAb);
}

// 28-Sep-2019, tatu: I do not fully understand what this method tried to do;
// it seemed to be a contribution from July 2016. But I noticed that it breaks
// with JDK 12 and unlikely to be allowed so let's comment it out.
/*
static class CheckGeneratedSerializerName {
public String stringField;
}
@SuppressWarnings("unchecked")
public void testGeneratedSerializerName() throws Exception {
CheckGeneratedSerializerName bean = new CheckGeneratedSerializerName();
Expand Down Expand Up @@ -238,4 +240,5 @@ public void testGeneratedSerializerName() throws Exception {
}
assertTrue("Expected class not found:" + expectedClassName, found);
}
*/
}

0 comments on commit b96ccd2

Please sign in to comment.