Add a failing test for #178

parameter-names/src/test/java/com/fasterxml/jackson/module/paramnames/JsonCreatorTest.java

@@ -2,39 +2,37 @@
 
 import com.fasterxml.jackson.annotation.*;
 import com.fasterxml.jackson.databind.*;
+
 import org.junit.*;
 
 import static org.assertj.core.api.BDDAssertions.*;
 
-public class JsonCreatorTest
+public class JsonCreatorTest extends ModuleTestBase
 {
-	@Test
-	public void shouldDeserializeClassWithJsonCreatorOnStaticMethod() throws Exception {
-
-		// given
-		ObjectMapper objectMapper = new ObjectMapper();
-		objectMapper.registerModule(new ParameterNamesModule());
-
+    static class ClassWithJsonCreatorOnStaticMethod {
+        final String first;
+        final String second;
+
+        ClassWithJsonCreatorOnStaticMethod(String first, String second) {
+             this.first = first;
+             this.second = second;
+        }
+
+        @JsonCreator
+        static ClassWithJsonCreatorOnStaticMethod factory(String first, String second) {
+             return new ClassWithJsonCreatorOnStaticMethod(first, second);
+        }
+    }
+
+    private final ObjectMapper MAPPER = newMapper();
+
+    @Test
+    public void testJsonCreatorOnStaticMethod() throws Exception
+    {
 		// when
-		String json = "{\"first\":\"1st\",\"second\":\"2nd\"}";
-		ClassWithJsonCreatorOnStaticMethod actual = objectMapper.readValue(json, ClassWithJsonCreatorOnStaticMethod.class);
+		String json = a2q("{'first':'1st','second':'2nd'}");
+		ClassWithJsonCreatorOnStaticMethod actual = MAPPER.readValue(json, ClassWithJsonCreatorOnStaticMethod.class);
 
 		then(actual).isEqualToComparingFieldByField(new ClassWithJsonCreatorOnStaticMethod("1st", "2nd"));
-	}
-
-	static class ClassWithJsonCreatorOnStaticMethod {
-		final String first;
-		final String second;
-
-		ClassWithJsonCreatorOnStaticMethod(String first, String second) {
-			this.first = first;
-			this.second = second;
-		}
-
-		@JsonCreator
-		static ClassWithJsonCreatorOnStaticMethod factory(String first, String second) {
-
-			return new ClassWithJsonCreatorOnStaticMethod(first, second);
-		}
-	}
+    }
 }

parameter-names/src/test/java/com/fasterxml/jackson/module/paramnames/ModuleTestBase.java

@@ -17,11 +17,11 @@ protected static JsonMapper.Builder mapperBuilder() {
                 .addModule(new ParameterNamesModule());
     }
 
-    protected String quote(String value) {
+    protected String q(String value) {
         return "\"" + value + "\"";
     }
 
-    protected String aposToQuotes(String json) {
+    protected String a2q(String json) {
         return json.replace("'", "\"");
     }
 

parameter-names/src/test/java/com/fasterxml/jackson/module/paramnames/failing/JsonCreator178Test.java

@@ -0,0 +1,33 @@
+package com.fasterxml.jackson.module.paramnames.failing;
+
+import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.fasterxml.jackson.module.paramnames.ModuleTestBase;
+
+import org.junit.*;
+
+import static org.junit.Assert.assertNotNull;
+
+public class JsonCreator178Test extends ModuleTestBase
+{
+    // [modules-base#178]
+    static class Bean178
+    {
+        int _a, _b;
+
+        public Bean178(@JsonDeserialize() int a, int b) {
+            _a = a;
+            _b = b;
+        }
+    }
+
+    private final ObjectMapper MAPPER = newMapper();
+
+    // [modules-base#178]
+    @Test
+    public void testJsonCreatorWithOtherAnnotations() throws Exception
+    {
+        Bean178 bean = MAPPER.readValue(a2q("{'a':1,'b':2}"), Bean178.class);
+        assertNotNull(bean);
+    }
+}