Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

About release version scheme #2194

Closed
chenrui333 opened this issue Nov 22, 2022 · 4 comments
Closed

About release version scheme #2194

chenrui333 opened this issue Nov 22, 2022 · 4 comments

Comments

@chenrui333
Copy link

I know featurebase is derived from pilosa, but the latest release for pilosa was 1.4.1, and it looks like the new community version for featurebase is with v1.0.0-community? Just curious, why not just use v2.0.0 instead?

Asking because I am thinking to revive the homebrew formula, but the version scheme really bothers me. Thanks!

@kordless
Copy link
Contributor

I am in agreement with you regarding the version number and do wish we had put more thought into it before the re-release a few months ago.

I was thinking about this while doing the last release, so I'm grateful you opened this issue for discussion.

Within a release or two, SQL3 should be fully integrated into the UI and likely made the default query method. Technically, a major version bump at that time would make sense due to the API becoming incompatible with previous releases. As it stands right now, these versions still support the older calling methods...

@chenrui333
Copy link
Author

chenrui333 commented Nov 30, 2022

I am in agreement with you regarding the version number and do wish we had put more thought into it before the re-release a few months ago.

I was thinking about this while doing the last release, so I'm grateful you opened this issue for discussion.

No worries, trying to help here. :)

Within a release or two, SQL3 should be fully integrated into the UI and likely made the default query method. Technically, a major version bump at that time would make sense due to the API becoming incompatible with previous releases. As it stands right now, these versions still support the older calling methods...

The project renaming should already granted the major release (the artifact got name change?), and regarding the API version stuff, I think either it would be managed separately (I see somebody are doing that), or, we can just do another major version bump regarding the incompatibility part.

Let me know if that makes sense.

@kordless
Copy link
Contributor

kordless commented Dec 13, 2022

@chenrui333 we've done a new release and have changed the version to match internal versions of the binaries. Please let me know your thoughts on this and anything we might need to do to assist you with the homebrew formula.

@kordless
Copy link
Contributor

Closing this as the versions are now updated! @chenrui333 be sure to join our Discord if you need anything!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants