Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pilosa: deprecate #95805

Closed
wants to merge 1 commit into from
Closed

pilosa: deprecate #95805

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 24, 2022

See FeatureBaseDB/featurebase#2149 (comment)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 24, 2022
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue labels Feb 24, 2022
@iMichka iMichka mentioned this pull request Feb 24, 2022
Closed
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@iMichka iMichka deleted the pilosa branch March 1, 2022 20:36
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
chenrui333
chenrui333 reviewed Nov 22, 2022
View reviewed changes
Formula/pilosa.rb
Comment on lines +15 to +16
# https://github.com/pilosa/pilosa/issues/2149#issuecomment-993029527
deprecate! date: "2021-12-14", because: :unmaintained
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have revived the project, but need some work to update the build/test.

Also there is some issue with the version scheme, FeatureBaseDB/featurebase#2194

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iMichka @BrewTestBot @SMillerDev @chenrui333