Fix PointEvalHandler when first point is missing + add some kwargs #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Jul 12, 2022
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 22 22
Lines 3405 3407 +2
=======================================
+ Hits 3110 3112 +2
Misses 295 295
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PointEvalHandlercould not be constructed when the first point was not found.Also adds keyword arguments for how many neigboring points to use and whether or not to print warnings for not found points. The former was a random hard-coded choice in the first place (so perhaps better allow the user to change it if necessary) and the latter is useful if many points are expected to not be found.